Repository navigation
[6.x] Fix drag handle shifting when a second Grid row or Replicator set is added - #15913
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks for the pull request! 🙌 I've updated the Grid screenshots in the PR description. The old before/after ones looked identical, so I've updated them to show 1 row & 2 rows so you can see the shift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a second row to a Grid makes the drag handle grow and pushes the column labels to the right. The same happens to a Replicator set's header when a second set is added.
Since #15592, the drag handle only gets its
p-1padding whenkeyboard-reorderis on, and Grid rows and Replicator sets only turn that on once there are two or more items. So the handle goes from 7px to 15px wide when the second item appears.This makes the padding part of the handle's base classes, so it's the same size either way. The only other place using the handle, Customize Columns, now gets the same padded handle as Grid.
Fixes #15885
🤖 Generated with Claude Code