Repository navigation
Conversation
NickLarsenNZ
left a comment
There was a problem hiding this comment.
I assume there's no Cargo.nix
It was actually very rarely used and thus gitignored. Added it now |
There was a problem hiding this comment.
This change was needed, as opentelemetry-otlp dropped the serialize feature
|
pre-commit complains about a missing newline in |
We should add it to the exclusions (any generated file should be excluded from lints). |
|
@NickLarsenNZ I removed the newline, as we also don't seem to have it for our operators |
There was a problem hiding this comment.
I would instead change the prek config to ignore it.
I will approve anyway, but it will come back again unless we edit the config.
There was a problem hiding this comment.
Ahh I was looking for that, thanks! Fixed in 71fa834
Description
Docs
Release note
Checklist
Author
Reviewer
Acceptance