Skip to content

chore: Dependency updates - #125

Open
sbernauer wants to merge 10 commits into
mainfrom
chore/upgrades-2026-11-17
Open

sbernauer wants to merge 10 commits into
mainfrom
chore/upgrades-2026-11-17

Conversation

@sbernauer

@sbernauer sbernauer commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Description

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@sbernauer sbernauer self-assigned this Nov 17, 2026
@sbernauer
sbernauer requested a review from a team November 17, 2026 07:14
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Nov 17, 2026
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there's no Cargo.nix

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 17, 2026
@sbernauer

Copy link
Copy Markdown
Member Author

I assume there's no Cargo.nix

It was actually very rarely used and thus gitignored. Added it now

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was needed, as opentelemetry-otlp dropped the serialize feature

@sbernauer

Copy link
Copy Markdown
Member Author

pre-commit complains about a missing newline in Cargo.nix, can be ignored

@NickLarsenNZ

Copy link
Copy Markdown
Member

pre-commit complains about a missing newline in Cargo.nix, can be ignored

We should add it to the exclusions (any generated file should be excluded from lints).

NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026
@sbernauer

Copy link
Copy Markdown
Member Author

@NickLarsenNZ I removed the newline, as we also don't seem to have it for our operators

Comment thread Cargo.nix

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would instead change the prek config to ignore it.

See: https://github.com/stackabletech/zookeeper-operator/blob/9e4be9daf154e5efa22deb0db43d532952d2d4be/.pre-commit-config.yaml#L4

I will approve anyway, but it will come back again unless we edit the config.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I was looking for that, thanks! Fixed in 71fa834

NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants