Repository navigation
Include SpdxFiles with no name in the package verification code - #459
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
A file with no name cannot match any of the skipped file paths, so it should still contribute its SHA1 to the digest instead of being dropped. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Member
|
I just merged #458 - so please rebase and I can merge in this fix |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SpdxFile[]overload ofgeneratePackageVerificationCodeadds a file's SHA1 only whengetName()is present. ThatisPresent()keeps a null out ofTreeSet.contains, but it also gates the add, so a file with no name is dropped from the digest rather than treated as not skipped. One unnamed file plus one excluded file currently hashes to the SHA1 of the empty string.An absent name cannot match a skipped path, so only consult the set when there is a name. The new test covers the plain and the skipped case.
This touches the same two lines as #458. Please say which you would rather take first and I will rebase the other.