Repository navigation
fix/observability: Prometheus read only root volume - #1479
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
marcleblanc2
changed the title
marcleblanc2
marked this pull request as ready for review
November 11, 2026 03:59
The prometheus image now keeps Alertmanager's configuration and state on the /prometheus data volume, so nothing writes to the root filesystem. Needs sourcegraph/sourcegraph#18737 in the pinned image. Amp-Thread-ID: https://ampcode.com/threads/T-01a13cfb-9756-7111-8b29-381a841065e1 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/prometheus-read-only-root-filesystem
branch
from
November 13, 2026 05:56
533bfae to
1d28bde
Compare
marcleblanc2
enabled stacked auto-merge (squash)
November 13, 2026 06:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some customers need a read-only root filesystem on every container, and still need Alertmanager to work
The
prometheusservice couldn't beread_only, because Alertmanager wrote to the root filesystemSolution
Add
read_only: trueto theprometheusservicesourcegraph/sourcegraph#18737 moves Alertmanager's files onto the
/prometheusdata volume.Do not merge this PR until the pinned
prometheusimage includes it.Test plan
Ran this branch with the image Buildkite built from sourcegraph/sourcegraph#18737:
prometheusstarts read-only, with no read-only or permission errorsobservability.alertsandobservability.silenceAlertsreach Alertmanager, and a webhook receives the notificationsmainwith the releasedprometheus:8.1.4690to this branch works on the same volumedocker compose stoptakes 0.5 seconds, so the default 10 second grace period is enoughprometheus:8.1.4690fails withopen /sg_config_prometheus/alertmanager.yml: read-only file systemLinked PRs
Merge in this order, because the two deploy PRs need a
prometheusimage with the fix:Amp threads