Repository navigation
fix(server): serve the page for HEAD when the GET handler returns nothing - #2376
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b96fccb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
brenelz
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
GEThandler returns nothing #2375What is the current behavior?
A route file that exports a page and a
GEThandler falls through to the page whenGETreturns nothing. AHEADrequest runs the sameGEThandler, but the server only allows the fall-through forGET, soHEADthrows "API handler for HEAD ... did not return a response." and answers 500.With the
[...404].tsxinapps/tests,HEAD /no-such-pagereturns 500 whileGET /no-such-pagereturns the 404 page.What is the new behavior?
HEADfalls through the same wayGETdoes, so it gets the same status and headers as the matchingGET. Other methods still throw when their handler returns nothing.The new e2e test in
apps/tests/src/e2e/api-call.test.tssendsGETandHEADto an unmatched URL and checks that both return 404 with the same content type. It fails on main (Expected: 404, Received: 500) and passes with this change.Other information
The
1.xbranch has the same check inpackages/start/src/server/handler.tsand needs the same one-line change.