Repository navigation
fix: make the TanStack Start output work with current TanStack Start - #3
Merged
Merged
Conversation
TanStack Start decodes the payload search parameter of a GET server function call with seroval's fromJSON, which rejects the plain JSON the compiled component sent. The new createTanstackImageUrl helper encodes the payload with seroval. The generated code also imports createServerFn from @tanstack/solid-start and no longer passes the response option, which createServerFn does not take. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lxsmnsyc
force-pushed
the
feat/oxc-compiler
branch
from
November 11, 2026 14:14
d603f0a to
e73a387
Compare
lxsmnsyc
force-pushed
the
fix/tanstack-start-output
branch
from
November 11, 2026 14:14
e34027e to
7348fa3
Compare
davedbase
marked this pull request as ready for review
November 11, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2
Fixes the TanStack Start output. Current TanStack Start rejects the url that the compiled component builds, so the image never renders.
Changes
createTanstackImageUrl(url, values)to@solidjs/ogp. It encodes{ data: { values } }with seroval'stoJSON, which is how TanStack Start's client sends a GET payload, and appends it as thepayloadsearch parameter.JSON.stringifyand the extra&createServerFn&rawparameters.createServerFnfrom@tanstack/solid-start, and calls it with{ method: 'GET' }only.createServerFnhas noresponseoption.x-tsr-serverFnheader, so TanStack Start sends the returnedResponseas is. That part needs no change.Proof
feat/oxc-compiler: TanStack Start's handler (@tanstack/start-server-core1.169.26) reads the payload withfromJSON(JSON.parse(payload)). For the payload the old output sends:node -e "require('seroval').fromJSON(JSON.parse(JSON.stringify({ data: { values: ['hello'] }, context: {} })))"throwsSeroval Error (step: 3).pnpm --filter @solidjs/ogp exec vitest run tests/tanstack.test.tsbuilds urls with the helper and decodes them the same way, getting back{ data: { values } }.Changeset
minor(tanstack-start-image-url.md): the fix, plus the newcreateTanstackImageUrlexport.Checks
Roadmap
Cost
seroval@^1.7.0.@solidjs/weband TanStack Start already depend on seroval 1.x.Risk
@tanstack/start-client-core1.170.22,@tanstack/start-server-core1.169.26), not in a running TanStack Start app.@tanstack/solid-start2.0.0-rc.10, peersolid-js >=2.0.0-rc.20).🤖 Generated with Claude Code