Repository navigation
fix(Virtual): finish active scroll when duration becomes zero - #85
Open
Marshallup wants to merge 1 commit into
Open
Marshallup wants to merge 1 commit into
Marshallup wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing a reactive
animationSettings.durationto0whileVirtualRoworVirtualColumnis scrolling leaves the existinganimation running with its original settings.
This PR stops that animation and immediately places the list at
its target position. Both scheduled and running controllers are
handled.
Tests
Added DOM and WebGL regression tests for both axes, including
disabling animation before the first frame and during scrolling.
Focus, subsequent navigation, and re-enabling animations are covered.
All 6 new cases fail without the fix and pass with it.
pnpm test: 757 passed, 13 skipped.pnpm test:webgl: 23 passed.pnpm buildandpnpm lintpass; existing lint warnings remain.