Repository navigation
chore: drop setup.cfg and configure metadata in pyproject.toml only - #2015
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
=======================================
Coverage 84.38% 84.38%
=======================================
Files 118 118
Lines 13812 13812
=======================================
Hits 11655 11655
Misses 2157 2157 ☔ View full report in Codecov by Harness. |
srtaalej
left a comment
There was a problem hiding this comment.
Tested locally following the steps in the description:
./scripts/build_pypi_package.shbuilds the sdist + wheel andtwine checkpasses on both.- Installed the wheel in a fresh venv (pip 26.3):
pip show slack-sdkmatches the current 3.46.0 release from PyPI exactly (Home-page,Author,Author-email,License).
Also confirmed the pip < 24.1 caveat (pip 24.0 shows an empty Home-page, Author fields still fine), and nothing else in the repo references setup.cfg. LGTM!
| dynamic = ["version", "readme", "optional-dependencies"] | ||
| description = "The Slack API Platform SDK for Python" | ||
| license = { text = "MIT" } | ||
| authors = [{ name = "Slack Technologies, LLC" }, { email = "opensource@slack.com" }] |
There was a problem hiding this comment.
Nice, splitting name and email into separate entries is what keeps Author: and Author-email: as two fields. A combined { name, email } entry would emit only Author-email: "Slack Technologies, LLC" <opensource@slack.com> and change the pip show output.
|
|
||
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/slackapi/python-slack-sdk" |
There was a problem hiding this comment.
Confirmed this shows up as Project-URL: Homepage, ... in METADATA instead of the old Home-page: header. pip 24.1+ maps it back to Home-page in pip show, while pip 24.0 shows it empty, matching the caveat in the description. Seems fine to me.
| dynamic = ["version", "readme", "authors", "optional-dependencies"] | ||
| dynamic = ["version", "readme", "optional-dependencies"] | ||
| description = "The Slack API Platform SDK for Python" | ||
| license = { text = "MIT" } |
There was a problem hiding this comment.
Not for this PR: setuptools warns that the table form of license is deprecated (and so is the license classifier). Moving to license = "MIT" needs setuptools>=77, which doesn't work with our Python 3.7 support, so maybe that's a follow-up once we drop older Pythons.
Summary
This pull request removes the legacy
setup.cfgso package metadata lives only inpyproject.toml, same as slackapi/bolt-python#1616.pip show slack-sdkoutput is unchanged (Home-page,Author,Author-email), so Configuring with pyproject.toml #1436 still holds.Home-page.Testing
./scripts/build_pypi_package.shdist/*.whlin a fresh venv and confirmpip show slack-sdkmatches the current releaseCategory
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.🤖 Generated with Claude Code