Repository navigation
Conversation
xenium_aligned_image took a 4-D aligned image to be interleaved RGB, (1, y, x, 3), and asserted that the last axis has length 3. A planar RGB OME-TIFF reads as (1, 3, y, x) and failed that assertion. Pick the axis order from the shape instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 66.60% 67.13% +0.52%
==========================================
Files 26 26
Lines 3345 3347 +2
==========================================
+ Hits 2228 2247 +19
+ Misses 1117 1100 -17
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xenium_aligned_imageassumes that a 4-D aligned image is interleaved RGB,(1, y, x, 3), so a planar RGB OME-TIFF (axesSYX), which reads as(1, 3, y, x), fails its assertion. The function now picks the axis order from the shape, so both layouts read.We hit this on Atera v1 bundles from Xenium Onboard Analysis 1.1.1, whose H&E image is planar. We haven't checked public Xenium bundles.
Tests: a new test writes the same image planar and interleaved and reads both to the same array. On main the planar case fails. The other 17 local failures in
tests/test_xenium.pyare example bundles that CI downloads.