Skip to content

Update LIBC - #394

Merged
qjivy merged 1 commit into
ruyisdk:mainfrom
joy2myself:main
Nov 4, 2026
Merged

qjivy merged 1 commit into
ruyisdk:mainfrom
joy2myself:main

Conversation

@joy2myself

@joy2myself joy2myself commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Expand the GLIBC and newlib vector math libraries with support for additional common floating-point functions.

New Features:

  • Add vectorized math support for additional GLIBC and newlib floating-point functions.

Documentation:

  • Document the newly ported GLIBC and newlib vector math functions in the biweekly report.

@qjivy
qjivy merged commit 137fe93 into ruyisdk:main Nov 4, 2026
1 check passed
@sourcery-ai

sourcery-ai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the biweekly report to document newly ported vector math functions in glibc and newlib, integrating them with each library’s existing vector-math framework.

File-Level Changes

Change Details Files
Document updates to vectorized math-function ports in the C library implementations.
  • Record ports of selected single-precision and related math functions into the existing glibc libmvec framework.
  • Record ports of a broader set of single-precision math functions into the existing newlib vector math framework.
20261105-ruyisdk-biweekly-80.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="20261105-ruyisdk-biweekly-80.md" line_range="38" />
<code_context>
 ### 基础C库

+- GLIBC:
+  - 移植了 sinpif, sqrt, sqrtf, tanf 至现有的 glibc libmvec 框架。
+- newlib:
+  - 移植了 atanhf, atan2f, atanpif, atan2pif, exp2f, cosf, coshf, cospif, exp10f, expf, log2f, log2p1f, rsqrtf, expm1f 至现有的 newlib 向量数学框架。
</code_context>
<issue_to_address>
**Vector math support is not added**

When the PR is expected to deliver the feature described in its summary, the change only adds report text and contains no GLIBC or newlib implementation changes, so the described vector-function support is not delivered by this PR.

Either include the GLIBC/newlib implementation changes or describe this PR as documentation-only.

Also at `20261105-ruyisdk-biweekly-80.md:40`.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: 20261105-ruyisdk-biweekly-80.md:38


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

### 基础C库

- GLIBC:
- 移植了 sinpif, sqrt, sqrtf, tanf 至现有的 glibc libmvec 框架。

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Vector math support is not added

When the PR is expected to deliver the feature described in its summary, the change only adds report text and contains no GLIBC or newlib implementation changes, so the described vector-function support is not delivered by this PR.

Either include the GLIBC/newlib implementation changes or describe this PR as documentation-only.

Also at 20261105-ruyisdk-biweekly-80.md:40.

Prompt for AI agents
In `20261105-ruyisdk-biweekly-80.md` at line 38:

**Vector math support is not added**

When the PR is expected to deliver the feature described in its summary, the change only adds report text and contains no GLIBC or newlib implementation changes, so the described vector-function support is not delivered by this PR.

Either include the GLIBC/newlib implementation changes or describe this PR as documentation-only.

Also at `20261105-ruyisdk-biweekly-80.md:40`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants