Repository navigation
Update LIBC - #394
Update LIBC#394
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the biweekly report to document newly ported vector math functions in glibc and newlib, integrating them with each library’s existing vector-math framework. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="20261105-ruyisdk-biweekly-80.md" line_range="38" />
<code_context>
### 基础C库
+- GLIBC:
+ - 移植了 sinpif, sqrt, sqrtf, tanf 至现有的 glibc libmvec 框架。
+- newlib:
+ - 移植了 atanhf, atan2f, atanpif, atan2pif, exp2f, cosf, coshf, cospif, exp10f, expf, log2f, log2p1f, rsqrtf, expm1f 至现有的 newlib 向量数学框架。
</code_context>
<issue_to_address>
**Vector math support is not added**
When the PR is expected to deliver the feature described in its summary, the change only adds report text and contains no GLIBC or newlib implementation changes, so the described vector-function support is not delivered by this PR.
Either include the GLIBC/newlib implementation changes or describe this PR as documentation-only.
Also at `20261105-ruyisdk-biweekly-80.md:40`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: 20261105-ruyisdk-biweekly-80.md:38
| ### 基础C库 | ||
|
|
||
| - GLIBC: | ||
| - 移植了 sinpif, sqrt, sqrtf, tanf 至现有的 glibc libmvec 框架。 |
There was a problem hiding this comment.
🟡 Medium · Vector math support is not added
When the PR is expected to deliver the feature described in its summary, the change only adds report text and contains no GLIBC or newlib implementation changes, so the described vector-function support is not delivered by this PR.
Either include the GLIBC/newlib implementation changes or describe this PR as documentation-only.
Also at 20261105-ruyisdk-biweekly-80.md:40.
Prompt for AI agents
In `20261105-ruyisdk-biweekly-80.md` at line 38:
**Vector math support is not added**
When the PR is expected to deliver the feature described in its summary, the change only adds report text and contains no GLIBC or newlib implementation changes, so the described vector-function support is not delivered by this PR.
Either include the GLIBC/newlib implementation changes or describe this PR as documentation-only.
Also at `20261105-ruyisdk-biweekly-80.md:40`.
Summary by Sourcery
Expand the GLIBC and newlib vector math libraries with support for additional common floating-point functions.
New Features:
Documentation: