Repository navigation
Audit excluded tests on JRuby and address differences #1123
Description
Several tests still explicitly exclude JRuby and do not run against the Java extension. We should reexamine these and fix as many differences with the C extension as possible.
$ git grep -e "RUBY_ENGINE == [\"']jruby" test
test/json/json_generator_test.rb: if RUBY_ENGINE == "jruby"
test/json/json_minefield_parser_test.rb: if RUBY_ENGINE == 'jruby'
test/json/json_parser_test.rb: unless RUBY_ENGINE == 'jruby'
test/json/json_parser_test.rb: omit "JRuby errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/json_parser_test.rb: omit "JRuby errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/json_parser_test.rb: omit "JRuby string decoding errors don't contain positions" if RUBY_ENGINE == "jruby"
test/json/resumable_parser_test.rb: omit "JRuby not supported" if RUBY_ENGINE == "jruby"
Some of these may be valid but most involve changes made to the C extension that were never ported to the Java extension. That last one excludes all of the ResumableParser tests because that entire feature is missing from the Java extension.
See #1122 for one example of a latent bug hidden by these masks.
Activity
headius commentedon Nov 4, 2026
Some of these are due to #138.