Skip to content

[tmva] Deprecate the deep learning methods and their build options - #24255

Merged
guitargeek merged 2 commits into
root-project:masterfrom
guitargeek:tmva-deprecate-dl
Nov 19, 2026
Merged

guitargeek merged 2 commits into
root-project:masterfrom
guitargeek:tmva-deprecate-dl

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

MethodDL, MethodDNN and the TMVA::DNN classes are deprecated and will be removed in ROOT 6.46. Neural networks are trained with dedicated machine learning libraries nowadays, so maintaining a separate implementation with CPU, CUDA and cuDNN backends is no longer justified.

The tmva-cpu, tmva-gpu, tmva-cudnn and use_gsl_cblas build options only affect these methods and are deprecated with them. The tmva-cpu option is now OFF by default, also with all=ON, so that only builds that ask for it get the configure-time warning. The tmva-cudnn option stays ON by default, but it only has an effect together with tmva-gpu, so it only warns in that case.

Both methods also warn at runtime, because users of pre-built binaries never see the configure-time warning.

Note that MethodDNN has actually been deprecated already 5 years ago in c600414, but just had no clear removal path.

MethodDL, MethodDNN and the TMVA::DNN classes are deprecated and will be
removed in ROOT 6.46. Neural networks are trained with dedicated machine
learning libraries nowadays, so maintaining a separate implementation
with CPU, CUDA and cuDNN backends is no longer justified.

The `tmva-cpu`, `tmva-gpu`, `tmva-cudnn` and `use_gsl_cblas` build
options only affect these methods and are deprecated with them. The
`tmva-cpu` option is now OFF by default, also with `all=ON`, so that
only builds that ask for it get the configure-time warning. The
`tmva-cudnn` option stays ON by default, but it only has an effect
together with `tmva-gpu`, so it only warns in that case.

Both methods also warn at runtime, because users of pre-built binaries
never see the configure-time warning.

Assisted-by: claude-code:claude-fable-5-2
The TMVA deep learning methods are deprecated, so the tutorials should
not promote them anymore:

  * TMVA_CNN_Classification and TMVA_RNN_Classification only make sense
    with these methods and are removed, together with the helper
    PyTorch_Generate_CNN_Model.py that nothing else uses.

  * The other TMVA tutorials no longer book the deep learning methods.
    TMVA_Higgs_Classification moves to the basic training tutorials in
    the index.

TMVAMulticlass and TMVA_Higgs_Classification are single-threaded now,
so they leave the list of multithreaded tutorial tests.
TMVA_Higgs_Classification.py is also dropped from the tutorials that
require TensorFlow, which it has not used since the removal of PyMVA,
and loses an unused import that the ruff CI job rejects.

Assisted-by: claude-code:claude-fable-5-2
@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 9h 50m 9s ⏱️
 3 889 tests  3 889 ✅ 0 💤 0 ❌
76 140 runs  76 140 ✅ 0 💤 0 ❌

Results for commit a515e27.

@guitargeek
guitargeek merged commit 934b808 into root-project:master Nov 19, 2026
33 of 34 checks passed
@guitargeek
guitargeek deleted the tmva-deprecate-dl branch November 19, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants