Skip to content

Nested missing dictionaries - #24236

Merged
pcanal merged 3 commits into
root-project:masterfrom
pcanal:nested_missing_dictionaries
Nov 19, 2026
Merged

pcanal merged 3 commits into
root-project:masterfrom
pcanal:nested_missing_dictionaries

Conversation

@pcanal

@pcanal pcanal commented Nov 18, 2026

Copy link
Copy Markdown
Member

Upgrade GetMissingDictionaries to recurse through classes with dictionaries

This allows to investigate the template argument of those classes; this particularly useful
for the case of std::pair and std::tuple (which have an implicit dictionary)

This upstream the spirit of cms-sw/cmssw#52201

This allows to investigate the template argument of those classes; this particularly useful
for the case of std::pair and std::tuple (which have an implicit dictionary)

This upstream the spirit of cms-sw/cmssw#52201
@pcanal
pcanal requested review from dpiparo and jblomer November 18, 2026 19:56
@pcanal pcanal self-assigned this Nov 18, 2026
@pcanal
pcanal requested a review from bellenot as a code owner November 18, 2026 19:56
@pcanal
pcanal removed the request for review from bellenot November 18, 2026 19:57
@dpiparo dpiparo added this to the 6.42.00 milestone Nov 18, 2026

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, but the test logic is a little heavy. Maybe that's the best way but I wonder if alternatives to the CMake-foo were considered.

@makortel

makortel commented Nov 18, 2026 •

Copy link
Copy Markdown

Thanks! Can this be backported down to 6.40?

@pcanal

pcanal commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Thanks!. Can this be backported down to 6.40?

Yes, it will be.

@pcanal

pcanal commented Nov 18, 2026 •

Copy link
Copy Markdown
Member Author

I think it's fine, but the test logic is a little heavy. Maybe that's the best way but I wonder if alternatives to the CMake-foo were considered.

Not really as we need to have various set of libraries with different classes with and without dictionaries.

Exercise missing-dictionary reporting across representative genreflex selections of wrapper and vector classes.

Assisted-by: copilot-sdk:gpt-6-luna
@pcanal
pcanal force-pushed the nested_missing_dictionaries branch from 0bcbef0 to 5787fc8 Compare November 18, 2026 23:04
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 12h 35m 33s ⏱️
 3 943 tests  3 942 ✅ 0 💤 1 ❌
77 260 runs  77 259 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 6c52337.

♻️ This comment has been updated with latest results.

@pcanal
pcanal merged commit 5f0bb3d into root-project:master Nov 19, 2026
32 of 34 checks passed
@pcanal

pcanal commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

/backport to 6.40, 6.42

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #24236 to branches 6.40 and 6.42 requested by pcanal

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants