Repository navigation
Nested missing dictionaries - #24236
Conversation
This allows to investigate the template argument of those classes; this particularly useful for the case of std::pair and std::tuple (which have an implicit dictionary) This upstream the spirit of cms-sw/cmssw#52201
jblomer
left a comment
There was a problem hiding this comment.
I think it's fine, but the test logic is a little heavy. Maybe that's the best way but I wonder if alternatives to the CMake-foo were considered.
|
Thanks! Can this be backported down to 6.40? |
Yes, it will be. |
Not really as we need to have various set of libraries with different classes with and without dictionaries. |
Exercise missing-dictionary reporting across representative genreflex selections of wrapper and vector classes. Assisted-by: copilot-sdk:gpt-6-luna
0bcbef0 to
5787fc8
Compare
Test Results 22 files 22 suites 3d 12h 35m 33s ⏱️ For more details on these failures, see this check. Results for commit 6c52337. ♻️ This comment has been updated with latest results. |
|
/backport to 6.40, 6.42 |
|
Preparing to backport PR #24236 to branches 6.40 and 6.42 requested by pcanal |
|
This PR has been backported to
|
Upgrade
GetMissingDictionariesto recurse through classes with dictionariesThis allows to investigate the template argument of those classes; this particularly useful
for the case of std::pair and std::tuple (which have an implicit dictionary)
This upstream the spirit of cms-sw/cmssw#52201