Skip to content

Adjust stressGraphics_web.ref - #24209

Merged
linev merged 1 commit into
root-project:masterfrom
linev:ff_stressgraphics_fix
Nov 18, 2026
Merged

linev merged 1 commit into
root-project:masterfrom
linev:ff_stressgraphics_fix

Conversation

@linev

@linev linev commented Nov 17, 2026

Copy link
Copy Markdown
Member

With newer firefox one test failing.
Because of changed formatting in firefox like
stroke-width: 1; -> stroke-width: 1px;

With newer firefox one test failing.
Because of changed formatting in firefox like
`stroke-width: 1;` -> `stroke-width: 1px;`
@hahnjo

hahnjo commented Nov 17, 2026

Copy link
Copy Markdown
Member

This obviously solves the failure, but I'm still confused why d3debe7 changed sgf_gmultierrors.C...

@linev

linev commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

Commit changes the way how primitives are iterated and checked when batch images for TCanvas are created.

This loop also has web-specific (canv->IsWeb()) handling.

Looking in diffs for sgf_gmultierrors.C - seems to be TMultiGraph::Paint() is invoked now which leads to creating of histogram and title for TMultiGraph object. It is absolutely normal situation for JSROOT - but leads for such tiny variation in SVG output.

One can try to investigate this - but I see it as minor issue for the moment.

@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 10h 58m 49s ⏱️
 3 886 tests  3 886 ✅ 0 💤 0 ❌
76 070 runs  76 070 ✅ 0 💤 0 ❌

Results for commit bba22fe.

@linev

linev commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

@hahnjo

My PR #24225 address the problem.
I call canv->Update() also for batch canvas - which is not required.
As I mention - it is not a bug and web canvas supports both variants.
I will backport only stressGraphics_web.ref modification to exclude failing tests in released version

@linev
linev merged commit bab566e into root-project:master Nov 18, 2026
34 checks passed
@linev

linev commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

/backport to 6.42

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #24209 to branch 6.42 requested by linev

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.42: #24226

@linev
linev deleted the ff_stressgraphics_fix branch November 18, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants