Skip to content

[cppjit] Autoparse names missing from namespaces [ROOT-patch] - #24185

Merged
guitargeek merged 3 commits into
root-project:masterfrom
guitargeek:rootmap-enum-autoload-24176
Nov 18, 2026
Merged

guitargeek merged 3 commits into
root-project:masterfrom
guitargeek:rootmap-enum-autoload-24176

Conversation

@guitargeek

Copy link
Copy Markdown
Contributor

Closes #24176.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 9h 16m 43s ⏱️
 3 889 tests  3 889 ✅ 0 💤 0 ❌
72 296 runs  72 296 ✅ 0 💤 0 ❌

Results for commit d69c2c8.

♻️ This comment has been updated with latest results.

@dpiparo

dpiparo commented Nov 17, 2026

Copy link
Copy Markdown
Member

Thanks. Do we understand why this feature ceased to function in the 6.42 branch? How is cppjit related?

@guitargeek

Copy link
Copy Markdown
Contributor Author

In 6.40, it worked because cppyy went through the higher-level TEnum abstraction, which triggered the autoparsing.

In 6.42, this has never worked so it didn't suddenly "cease to function" if that's what you mean. I'm actually surprised the report from ATLAS came so late here!

@guitargeek guitargeek mentioned this pull request Nov 17, 2026
1 task
Enums and variables known only from a rootmap, like the ATLAS xAOD enums
and constants, were not found. Rootmaps don't forward declare them, so
they only exist once their header is parsed. But interop::GetScope calls
TClass::GetClass first, which normalizes the name with autoloading off:
TCling can't autoparse it, and clang caches the failed lookup. Later
lookups never ask TCling again. The old cppyy checked for enums before
calling TClass::GetClass, so it was not affected.

If a name is missing from a namespace, ask TCling to autoparse it and
look again.

Closes root-project#24176.

Assisted-by: claude-code:claude-opus-5-5
Enums and variables that are only known from a rootmap must be
importable from their namespace before their header was parsed.

Assisted-by: claude-code:claude-opus-5-5
@guitargeek
guitargeek force-pushed the rootmap-enum-autoload-24176 branch from 145abff to ce9b058 Compare November 17, 2026 15:37
They are not pointing to the ROOT forks. The CppInterOp tag is
equivalent to the previous hash.
@guitargeek
guitargeek force-pushed the rootmap-enum-autoload-24176 branch from ce9b058 to d69c2c8 Compare November 17, 2026 15:42
@dpiparo

dpiparo commented Nov 18, 2026

Copy link
Copy Markdown
Member

ubu failures are unrelated.

@guitargeek
guitargeek merged commit 81438d3 into root-project:master Nov 18, 2026
36 of 37 checks passed
@guitargeek
guitargeek deleted the rootmap-enum-autoload-24176 branch November 18, 2026 07:46
@guitargeek

Copy link
Copy Markdown
Contributor Author

/backport to 6.42

@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #24185 to branch 6.42 requested by guitargeek

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.42: #24221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cppjit problem with enum

3 participants