Repository navigation
[cppjit] Autoparse names missing from namespaces [ROOT-patch] - #24185
Merged
guitargeek merged 3 commits intoNov 18, 2026
Merged
Conversation
guitargeek
requested review from
aaronj0,
bellenot and
dpiparo
as code owners
November 16, 2026 22:43
Test Results 21 files 21 suites 3d 9h 16m 43s ⏱️ Results for commit d69c2c8. ♻️ This comment has been updated with latest results. |
Member
|
Thanks. Do we understand why this feature ceased to function in the 6.42 branch? How is cppjit related? |
Contributor
Author
|
In 6.40, it worked because cppyy went through the higher-level In 6.42, this has never worked so it didn't suddenly "cease to function" if that's what you mean. I'm actually surprised the report from ATLAS came so late here! |
dpiparo
approved these changes
Nov 17, 2026
Enums and variables known only from a rootmap, like the ATLAS xAOD enums and constants, were not found. Rootmaps don't forward declare them, so they only exist once their header is parsed. But interop::GetScope calls TClass::GetClass first, which normalizes the name with autoloading off: TCling can't autoparse it, and clang caches the failed lookup. Later lookups never ask TCling again. The old cppyy checked for enums before calling TClass::GetClass, so it was not affected. If a name is missing from a namespace, ask TCling to autoparse it and look again. Closes root-project#24176. Assisted-by: claude-code:claude-opus-5-5
Enums and variables that are only known from a rootmap must be importable from their namespace before their header was parsed. Assisted-by: claude-code:claude-opus-5-5
guitargeek
force-pushed
the
rootmap-enum-autoload-24176
branch
from
November 17, 2026 15:37
145abff to
ce9b058
Compare
They are not pointing to the ROOT forks. The CppInterOp tag is equivalent to the previous hash.
guitargeek
force-pushed
the
rootmap-enum-autoload-24176
branch
from
November 17, 2026 15:42
ce9b058 to
d69c2c8
Compare
Member
|
ubu failures are unrelated. |
Contributor
Author
|
/backport to 6.42 |
|
Preparing to backport PR #24185 to branch 6.42 requested by guitargeek |
|
This PR has been backported to branch 6.42: #24221 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24176.