Repository navigation
[doc][ML] Update the RDataLoader documentation page - #23916
Merged
Merged
Conversation
The `*/bindings/pyroot/*.py` exclude pattern drops all the pythonization files found in the directory, only their module docstrings reach the documentation through the `extract_docstrings.py` script and attach on top of their C++ class reference docs pages. `RDataLoader` is a pure Python class with no C++ class page to attach to so its class and method docstrings just never appeared. Listing `_ml_dataloader.py` explicitly in the input ignores the exclude pattern for this file only.
siliataider
requested review from
dpiparo,
guitargeek and
vepadulano
as code owners
October 30, 2026 11:46
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2d71d66. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Oct 30, 2026
vepadulano
requested changes
Nov 16, 2026
vepadulano
left a comment
Member
There was a problem hiding this comment.
Thanks, this is great! Some comments for your consideration before final approval.
Assisted-by: Claude Opus 5.5
siliataider
force-pushed
the
rdataloader
branch
from
November 16, 2026 15:30
25b1e4d to
2d71d66
Compare
Contributor
Author
|
/backport to 6.42 |
|
Preparing to backport PR #23916 to branch 6.42 requested by siliataider |
|
This PR has been backported to branch 6.42: #24252 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout now is a walkthrough of a simple mock training script exploring all the features the RDataLoader offers.
You can preview the changes by downloading the page rendered as a PDF rdataloader-doc-preview.pdf