Repository navigation
fix(android): align timeZoneName native spec types - #1074
Open
pemalama12 wants to merge 1 commit into
Open
pemalama12 wants to merge 1 commit into
pemalama12 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the Android TurboModule timeZoneName spec changes.
No open issues 🎉
What changed in this PR
Aligns Android TurboModule timeZoneName specs with the public Flow/TypeScript API and native string handling, without changing public props or picker UI.
Changes:
- Corrects
timeZoneNamefrom an optional number to an optional string in both date-picker specs. - Adds optional string
timeZoneNamefields to both time-picker specs.
| File | Description |
|---|---|
src/specs/NativeModuleTimePicker.js |
Adds optional string timeZoneName. |
src/specs/NativeModuleMaterialTimePicker.js |
Adds optional string timeZoneName for Material time pickers. |
src/specs/NativeModuleMaterialDatePicker.js |
Corrects Material date-picker timeZoneName to a string. |
src/specs/NativeModuleDatePicker.js |
Corrects date-picker timeZoneName to a string. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the Android TurboModule
timeZoneNamecontract: use an optional string in the two date-picker specs and add it to the two time-picker specs. This matches the public Flow/TypeScript API andCommon.getTimeZone(), which reads an IANA timezone name withgetString().Test Plan
yarn test --runInBand: 31 tests and 3 snapshots pass.yarn lint: 0 errors, 22 existing warnings.Compatibility
Android spec correction. Public props and picker UI retain their existing API.
Checklist