Repository navigation
fix: bracket bare IPv6 literals for the gRPC channel target - #173
Merged
Merged
Conversation
ManagedChannelBuilder.forAddress("fd00::1", port) builds the channel
target dns:///fd00::1:6334, which gRPC cannot parse. Bracket bare IPv6
literals before creating the channel, mirroring what the Go client
does with net.JoinHostPort. Already-bracketed and hostname inputs are
unaffected.
anush008
approved these changes
Nov 5, 2026
anush008
left a comment
anush008
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to contribute @ivandasch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
createChannel, bracket the host when it is a bare IPv6 literal (contains:and no brackets) before callingManagedChannelBuilder.forAddress, so the channel target becomesdns:///[fd00::1]:6334and parses correctly.Already-bracketed hosts and hostnames are unaffected.
Mirrors the Go client behavior (
net.JoinHostPortingetAddr).Fixes #172