Repository navigation
[PyMySQL] Sync ER constants with PyMySQL 1.2.4 - #16753
Merged
srittau merged 2 commits intoNov 11, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Bumped the version to ~=1.2.4, since the new constants only exist from PyMySQL 1.2.4. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stubtest for PyMySQL reported three mismatches in
pymysql.constants.ER. This PR fixes them instubs/PyMySQL/pymysql/constants/ER.pyi:ERROR_LAST, which no longer exists at runtime.MUST_CHANGE_PASSWORD = 1820.MUST_CHANGE_PASSWORD_LOGIN = 1862.I grepped the PyMySQL stubs and nothing else references
ER.ERROR_LAST.CR_ERROR_LASTinCR.pyiis a different constant and I left it alone. Ruff passes on the changed file, andtests/stubtest_third_party.py PyMySQLpassed in my run.