Repository navigation
Conversation
Member
There was a problem hiding this comment.
Please update:
If 'ca_certs' is specified, validate the server cert against it and
check that it matches the hostname.
Same for docs.
JFYI, we generally prefer to open these in the private fork first to straighten out such things, but this is small so we should be fine.
Author
There was a problem hiding this comment.
Please update:
Both done.
JFYI, we generally prefer to open these in the private fork first to straighten out such things, but this is small so we should be fine.
Heard, Seth suggested working on this one in public just because it's low-impact (and I needed an issue number for the blurb anyway).
Documentation build overview
|
sethmlarson
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch implements the suggested fix along with a test that fails on current main. CC @sethmlarson @StanFromIreland
ssl.get_server_certificate(addr, ca_certs=...)verifies the chain but never the identity #161503