Repository navigation
Conversation
agammann
reviewed
Nov 7, 2026
agammann
left a comment
There was a problem hiding this comment.
__getnewargs__ supplies the tuple’s two fields as separate arguments to HeaderTuple.__new__, so copy and pickle reconstruct both values instead of nesting them as one item. The tests cover both concrete header classes, shallow and deep copy, every pickle protocol, and re-encoding a copied decoder result. I reviewed the patch and tests; I did not run them locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the two fields of
HeaderTupleandNeverIndexedHeaderTuplewhen they are copied or serialized. The inherited tuple reconstruction hook passes the entire pair as one argument to these classes' variadic constructor; copying or pickling therefore nests the pair, and re-encoding a copied decoded header can raiseIndexError.__getnewargs__()now supplies the two fields as separate constructor arguments. The change also adds copy, deepcopy, pickle-protocol, and decode–copy–encode regressions, plus a changelog entry.Validation
AI assistance was used to prepare the implementation, tests, and this description.