Repository navigation
Conversation
teunbrand
commented
Nov 13, 2026
| /// Validate `properties` against `definitions` and resolve each parameter | ||
| /// to its effective value: the user's value if present, otherwise the | ||
| /// definition's default. Returns a new map with defaults filled. | ||
| pub fn resolve_parameters( |
Collaborator
Author
There was a problem hiding this comment.
This is the main function to understand
teunbrand
commented
Nov 13, 2026
|
|
||
| // Handle ncol/nrow for wrap facets | ||
| if facet.is_wrap() { | ||
| let has_ncol = facet.properties.contains_key("ncol"); |
Collaborator
Author
There was a problem hiding this comment.
This had a bug where FACET foo SETTING ncol => null skips compute_default_ncol() and we had an unresolved setting.
teunbrand
force-pushed
the
param-validation
branch
from
November 16, 2026 12:04
a771bfb to
e03664e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #586.
Briefly, core validation/resolution logic is implemented as
ParameterDefinitionmethods.Helper wraps this to loop over ParameterDefinition and Parameters list and checks for extra (unknown) parameters.