Skip to content

fix(proxy): treat the SSE endpoint as a public path - #4080

Open
dragonchaser wants to merge 1 commit into
opencloud-eu:mainfrom
dragonchaser:backport-wp3-781
Open

dragonchaser wants to merge 1 commit into
opencloud-eu:mainfrom
dragonchaser:backport-wp3-781

Conversation

@dragonchaser

Copy link
Copy Markdown
Member

The proxy now treats /ocs/v2.php/apps/notifications/api/v1/notifications/sse as a public path, so requests with a public link token reach the SSE service; side effect: app tokens and guest link sessions are no longer authenticated on this endpoint, and requests without valid credentials are passed on instead of getting a 401.

AI assistance: Claude Code (claude-fable-5-2) applied the change and tested its effect on the proxy authenticators.

@codacy-production

codacy-production Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Up to standards βœ…

🟒 Issues 0 issues

Results:
0 new issues

View in Codacy

🟒 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

🟒 Coverage βˆ… diff coverage Β· +0.00% coverage variation

Metric Results
Coverage variation βœ… +0.00% coverage variation (-1.00%)
Diff coverage βœ… βˆ… diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2dc0668) 94300 28339 30.05%
Head commit (50d27d8) 94300 (+0) 28343 (+4) 30.06% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4080) 0 0 βˆ… (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@dragonchaser
dragonchaser marked this pull request as ready for review November 20, 2026 13:25
@dragonchaser
dragonchaser requested a review from butonic November 20, 2026 13:25
@dragonchaser dragonchaser added the Type:Maintenance E.g. technical debt, packaging, etc. label Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants