Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
🟢 Coverage 0.00% diff coverage · -0.01% coverage variation
Metric Results Coverage variation ✅ -0.01% coverage variation (-1.00%) Diff coverage ✅ 0.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (43211c1) 94312 28356 30.07% Head commit (38e836b) 94350 (+38) 28354 (-2) 30.05% (-0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3876) 42 0 0.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
rhafer
left a comment
There was a problem hiding this comment.
Once the Reva fix is included, tests/acceptance/features/apiSpaces/spaceManagement.feature:52-79 will fail: it explicitly expects a Space Admin to see another user’s personal space. The disable scenario at lines 153–162 also expects the old access behavior.
Maybe it's worth to have a CI run of this together with the related reva bump?
c28121b to
64fd66b
Compare
|
Hi @maki5, I had a look at the failed CI run of this PR (pipeline 5059), in case it helps:
The disable scenario rhafer mentioned already expects |
c7a3171 to
afc7886
Compare
|
@rhafer @aduffeck @pbleser-oc I rebased this pr and fixed the failing tests, the reva pr is also rebased and for now referenced in this pr, if you are ok with the changes I would be happy to start merging reva and this pr to main |
|
Thanks @maki5, the rebase fixed the unit test, and the |
…cted by permissions change
0736dac to
38e836b
Compare
depends on: opencloud-eu/reva#963
closes: #2979