Skip to content

fix(cli): remove obsolete xattrs metadata backend support - #3840

Merged
asaah262 merged 2 commits into
opencloud-eu:mainfrom
asaah262:fix/3048-deprecate-and-remove-xattrs-metadata
Nov 20, 2026
Merged

asaah262 merged 2 commits into
opencloud-eu:mainfrom
asaah262:fix/3048-deprecate-and-remove-xattrs-metadata

Conversation

@asaah262

@asaah262 asaah262 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Remove the obsolete xattrs metadata backend selection from OpenCloud's decomposedfs CLI.

  • Remove the reference to metadata.NewXattrsBackend(), which is being removed from Reva.
  • Keep the existing MessagePack backend selection unchanged.
  • Preserve the existing NullBackend fallback for unsupported metadata backends.
  • Add unit tests covering MessagePack and xattrs backend selection.

Related Issue

Motivation and Context

The modern XattrsBackend implementation is being removed from Reva as part of issue #3048.

OpenCloud's decomposedfs CLI still references NewXattrsBackend(), which causes a compilation error when building OpenCloud against the updated Reva.

Since OpenCloud does not expose the obsolete xattrs metadata backend as a configurable option, this change removes the unused reference while preserving the existing MessagePack functionality.

How Has This Been Tested?

  • Test environment: macOS, using OpenCloud with both its vendored Reva dependency and a modified local Reva worktree through go.work.
  • Test case 1: Verify that backend("mpk") returns MessagePackBackend.
  • Test case 2: Verify that backend("xattrs") returns NullBackend.

Validation commands:

GOWORK=off go test -mod=vendor ./opencloud/pkg/command -run '^TestBackend$' -count=1 -v
go test ./opencloud/pkg/command -count=1
go build ./...

All checks passed.

Screenshots (if appropriate)

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

AI assistance: Claude Code (claude-opus-5-5) wrote the first draft of the code and the tests.

@codacy-production

codacy-production Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 6 complexity

Metric Results
Complexity 6

View in Codacy

🟢 Coverage 34.62% diff coverage · +0.01% coverage variation

Metric Results
Coverage variation ✅ +0.01% coverage variation (-1.00%)
Diff coverage ✅ 34.62% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f8a8ecf) 94293 28310 30.02%
Head commit (dff314b) 94305 (+12) 28327 (+17) 30.04% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3840) 26 9 34.62%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@maki5 maki5 removed the status in OpenCloud Team Board Oct 28, 2026
@rhafer

rhafer commented Nov 5, 2026

Copy link
Copy Markdown
Member

Requires merging opencloud-eu/reva#923 before merging this PR

Does it? I think it would be easier to merge this PR first. Woudn't it?

@asaah262

asaah262 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Requires merging opencloud-eu/reva#923 before merging this PR

Does it? I think it would be easier to merge this PR first. Woudn't it?

You're right, thanks for pointing that out!
I've just re-run the tests and builds with both the current vendored Reva and my modified local Reva through go.work. Everything passed in both cases.
I'll update the PR description to remove the dependency note.

@asaah262
asaah262 marked this pull request as ready for review November 6, 2026 12:54
@asaah262 asaah262 linked an issue Nov 6, 2026 that may be closed by this pull request

@pbleser-oc pbleser-oc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I ran the tests of opencloud/pkg/command locally against the vendored reva; since this only drops a call, it also builds before the reva bump.

Comment thread opencloud/pkg/command/decomposedfs.go Resolved
@asaah262
asaah262 force-pushed the fix/3048-deprecate-and-remove-xattrs-metadata branch from d1e55a6 to dff314b Compare November 18, 2026 14:59
@asaah262
asaah262 requested a review from pbleser-oc November 18, 2026 15:03

@pbleser-oc pbleser-oc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, failing with an error is much better than printing empty metadata. Looks good to me.

@asaah262
asaah262 merged commit 43211c1 into opencloud-eu:main Nov 20, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:Backend Type:Maintenance E.g. technical debt, packaging, etc.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

deprecate and remove xattrs metadata backend

3 participants