Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
🟢 Coverage 34.62% diff coverage · +0.01% coverage variation
Metric Results Coverage variation ✅ +0.01% coverage variation (-1.00%) Diff coverage ✅ 34.62% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f8a8ecf) 94293 28310 30.02% Head commit (dff314b) 94305 (+12) 28327 (+17) 30.04% (+0.01%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3840) 26 9 34.62% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Does it? I think it would be easier to merge this PR first. Woudn't it? |
You're right, thanks for pointing that out! |
pbleser-oc
left a comment
There was a problem hiding this comment.
Looks good to me. I ran the tests of opencloud/pkg/command locally against the vendored reva; since this only drops a call, it also builds before the reva bump.
d1e55a6 to
dff314b
Compare
pbleser-oc
left a comment
There was a problem hiding this comment.
Thanks, failing with an error is much better than printing empty metadata. Looks good to me.
Description
Remove the obsolete
xattrsmetadata backend selection from OpenCloud's decomposedfs CLI.metadata.NewXattrsBackend(), which is being removed from Reva.NullBackendfallback for unsupported metadata backends.Related Issue
Motivation and Context
The modern
XattrsBackendimplementation is being removed from Reva as part of issue #3048.OpenCloud's decomposedfs CLI still references
NewXattrsBackend(), which causes a compilation error when building OpenCloud against the updated Reva.Since OpenCloud does not expose the obsolete xattrs metadata backend as a configurable option, this change removes the unused reference while preserving the existing MessagePack functionality.
How Has This Been Tested?
go.work.backend("mpk")returnsMessagePackBackend.backend("xattrs")returnsNullBackend.Validation commands:
All checks passed.
Screenshots (if appropriate)
Not applicable.
Types of changes
Checklist
AI assistance: Claude Code (claude-opus-5-5) wrote the first draft of the code and the tests.