Skip to content

fix: show shares in the system file picker - #264

Open
welcometopwn wants to merge 2 commits into
opencloud-eu:mainfrom
welcometopwn:fix/documents_provider_shares
Open

welcometopwn wants to merge 2 commits into
opencloud-eu:mainfrom
welcometopwn:fix/documents_provider_shares

Conversation

@welcometopwn

Copy link
Copy Markdown

Fixes #214

The documents provider only lists personal and project spaces at the account root, so shares can't be reached from the system file picker.

Fix

  • DocumentsStorageProvider adds the Shares root folder (GetSharesRootFolderForAccount, same as the Shares tab) to the account root, next to the spaces.
  • SpaceCursor.addSharesRoot() builds that row: "Shares" as name, shared icon, no create flag since you can't add files to the Shares folder itself. Inside a share the usual permissions apply.

Tested on a Galaxy S25+ (Android 17) with the Files app: Shares shows up next to Personal, the shared folders and their subfolders load and files open. detekt and the unit tests pass.

@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Nov 20, 2026
@kulmann kulmann moved this from Qualification to Needs Review in OpenCloud Team Board Nov 20, 2026
@kulmann
kulmann requested a review from wernrab November 20, 2026 09:44
@wernrab

wernrab commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Please have a closer look at the permissions. I was able to delete and rename shared documents and folders on the device (not on the server).

@welcometopwn

Copy link
Copy Markdown
Author

Fixed, thank you. Flags follow the server permissions now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

Shares not available in file explorer

2 participants