Repository navigation
fix: documents provider crashes on cold start before Koin is ready - #263
Open
welcometopwn wants to merge 1 commit into
Open
welcometopwn wants to merge 1 commit into
welcometopwn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238
If OpenCloud isn't running and another app opens one of its files through a saved SAF URI (a password manager reading its database, for example), Android starts OpenCloud just for the documents provider. The first query can come in on a binder thread while
MainApp.onCreate()hasn't finishedstartKoinyet, so it fails and the other app thinks the file is gone. Retrying works because Koin is up by then.On 1.2.5 this showed up as
NoBeanDefFoundException, on 1.3.1 I get:Fix
MainAppcounts down a latch oncestartKoinhas loaded all modules;awaitDependencyInjection()waits for it (10 s max, logs a warning on timeout).DocumentsStorageProvidergets a privateinject()that shadows Koin's extension: it waits for the latch, then resolves fromGlobalContext. All existingby inject()call sites stay unchanged.Tested on a Galaxy S25+ (Android 17): force-stopped both apps and let the other app read the file again. The store build fails on the first query, with this change it works.