Repository navigation
Preserve missing values in deviation normalization - #2483
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deviation normalization turns NaN and undefined into valid zeros when the non-missing series is constant. For example, normalizing
[2, 2, NaN]draws three dots instead of two; an entirely missing series can also produce invented observations.Use the existing
definedcheck before the zero-deviation fallback. Valid constant values still normalize to zero, while missing values stay missing. Added x/y, single-valid, all-missing and grouped regressions.Validation: all 405 native test files pass (1,355 tests, two skipped), including snapshots and types; whole-library lint, standalone TypeScript, formatting and all four release bundles pass. Independent Chromium replay passes 26 cases, including original facets and typed arrays, plus the 14 focused tests. The extra docs build is blocked by the same GitHub-star fetch on pristine and patched source under network denial.
Fixes #2482.