Skip to content

fix: prevent recursive tip options - #2481

Open
umrndem wants to merge 1 commit into
observablehq:mainfrom
umrndem:fix/tip-option-recursion
Open

umrndem wants to merge 1 commit into
observablehq:mainfrom
umrndem:fix/tip-option-recursion

Conversation

@umrndem

@umrndem umrndem commented Nov 16, 2026

Copy link
Copy Markdown

TipOptions inherits MarkOptions.tip, so TypeScript accepts nested tooltip options that the tip mark ignores at runtime. Exclude that property and add type regressions for nested options, the factory and the constructor. Shared mark and text styling remain supported.

Fixes #2459.

Validation: all 1,353 tests and type checks pass on CI's Node 24 runtime, with two existing skips. ESLint, Prettier and package builds pass. The documentation build completes; its existing SSR errors were reproduced on unchanged main. No runtime code or snapshots changed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Types] Wrong recursion in Mark’s _tip_ option

1 participant