Repository navigation
deps: update ngtcp2 to 1.26.0 - #67257
Open
nodejs-github-bot wants to merge 4 commits into
Open
nodejs-github-bot wants to merge 4 commits into
nodejs-github-bot wants to merge 4 commits into
Conversation
nodejs-github-bot
added
the
dependencies
Collaborator
Author
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
Contributor
|
Ideally your PR would make Node.js compatible with both ngtcp2 ≤1.25 and ngtcp2 ≥1.26 if that makes sense. If so, your PR can land first, then this PR can land |
Contributor
|
I can do it. But the problem is the test introduced with the PR, as it tests the problem that needs the new version from ngtcp2. |
Member
|
@martenrichter I'll fix up this PR. The build break is easy, but it looks like there's quite a few tests that fail, presumably due to other ngtcp2 changes. I'll push fixes here soon and then can merge this when that's resolved. |
Fix build failure due to new callback
Fix test failure: in the first test, we wait for stream then destroy it immediately. It looks like this ngtcp2 version fixes a bug where the error was never delivered to the remote peer in that case, but it now is, so the test needs to handle it.
ngtcp2 path validation timeouts now trigger retries in ngtcp2_conn_handle_expiry, which breaks tests where this happens while draining (when we shouldn't be sending anything at all - no retries). We can safely skip all expired timer handling once draining starts, which neatly guards against this and any other similar timers. OnTimeout here is firing for the drain timeout itself, managed by Node not ngtcp2, which we handle separately.
Member
|
3 separate fixes here, I've added them as separate fixups with explanations in the message for easier review. I think that covers everything, works for me, hopefully this'll pass the CI check 🤞 |
aduh95
approved these changes
Nov 5, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67257 +/- ##
==========================================
+ Coverage 90.68% 90.69% +0.01%
==========================================
Files 797 797
Lines 279367 279491 +124
Branches 53737 53766 +29
==========================================
+ Hits 253344 253487 +143
+ Misses 16319 16300 -19
Partials 9704 9704 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ngtcp2 to 1.26.0.