Skip to content

build: refresh markdown lint dependencies on lockfile changes - #67185

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:refresh-markdown-lint-dependencies
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:refresh-markdown-lint-dependencies

Conversation

@inoway46

@inoway46 inoway46 commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

make lint-md can keep using outdated dependencies after the lockfile changes. After #67023 updated remark-preset-lint-node to 5.2.0, which accepts alpha versions, my checkout still had 5.1.2 installed in tools/lint-md/node_modules, so make lint-md rejected valid alpha version entries in the API documentation:

doc/api/http.md
2008:1-2014:4 warning changes[0]: version(s) must respect the pattern `vx.x.x` oruse the placeholder `REPLACEME` nodejs-yaml-comments remark-lint

Reinstall dependencies when the lockfile changes, as the ESLint install rule already does, and recheck all Markdown files with the updated rules.

Verified that dependency updates trigger installation and linting, unchanged runs skip both, and make test-doc passes.

Refs: #67023

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Nov 1, 2026
@inoway46
inoway46 marked this pull request as ready for review November 1, 2026 12:42
@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (bf246cf) to head (798949d).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67185      +/-   ##
==========================================
- Coverage   90.69%   90.67%   -0.03%     
==========================================
  Files         797      797              
  Lines      278787   279577     +790     
  Branches    53610    53780     +170     
==========================================
+ Hits       252849   253501     +652     
- Misses      16310    16356      +46     
- Partials     9628     9720      +92     

see 60 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Reinstall markdown lint dependencies when the lockfile changes and
recheck all Markdown files with the updated rules.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@inoway46
inoway46 force-pushed the refresh-markdown-lint-dependencies branch from 5b9d37d to 798949d Compare November 6, 2026 05:46
@inoway46

inoway46 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@nodejs/build Could you take a look at this? This is not urgent, but fixes a local lint error that currently requires make lint-clean. Also, this should prevent future discrepancies between local and CI lint results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants