Repository navigation
fix: pass parse errors to transform callback instead of throwing - #38
Merged
Merged
Conversation
rvagg
reviewed
Nov 2, 2026
Member
|
needs a rebuil and comitted |
Co-authored-by: Rod Vagg <rod@vagg.org>
trivikr
force-pushed
the
fix-parse-error-callback
branch
from
November 2, 2026 07:57
346e844 to
38c1cc1
Compare
rvagg
approved these changes
Nov 2, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
## [3.0.1](v3.0.0...v3.0.1) (2026-11-02) ### Bug Fixes * pass parse errors to transform callback instead of throwing ([#38](#38)) ([f0d2a32](f0d2a32))
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commitStream()'stransformcalledaddLine()without atry/catch. When a line came before the firstcommitheader, the parse error was thrown out oftransformand never passed tocallback. A directwrite()threw synchronously instead of emitting'error'. The message (Something unexpected occurred) also didn't say what was wrong.This PR passes the error to
callback(err)and changes the message toUnexpected line before first "commit" header: <line>. It also adds regression tests forwrite()andpipeline().