Repository navigation
chore: remove split2 - #36
Merged
Merged
Conversation
rvagg
reviewed
Nov 2, 2026
| pipeline( | ||
| child.stdout, | ||
| split2(), | ||
| Readable.from(createInterface({ input: child.stdout, crlfDelay: Infinity })), |
Member
There was a problem hiding this comment.
pipeline accepts async iterables so you shouldn't need the Readable.from
rvagg
approved these changes
Nov 2, 2026
rvagg
left a comment
rvagg
left a comment
Member
There was a problem hiding this comment.
I'll follow this up with a couple of minor improvements
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 2, 2026
## [2.2.7](v2.2.6...v2.2.7) (2026-11-02) ### Trivial Changes * remove split2 ([#36](#36)) ([d67bff9](d67bff9))
|
🎉 This PR is included in version 2.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
split2with Node's built-innode:readlinefor splittinggit logoutput into lines.split2was only used in the tests and the README example, so the published package is unaffected.gitToListintest.jsnow waits for both the child process to close and the commit list callback to run before ending a test, becausereadlineadds async delay that could otherwise let a test finish before its assertions ran.