Skip to content

fix(submission): only accept a list of values as an answer - #3904

Merged
Chartman123 merged 1 commit into
mainfrom
fix/submission-answer-must-be-list
Nov 17, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/submission-answer-must-be-list

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Split out of #3833, so it can be merged and backported on its own. The commit drops out of #3833 once this is merged.

  • An answer is a list of values, and the answer to a grid question an object with the values by row, as the API describes it. Other values are rejected as an invalid answer with a 400 instead of failing with a server error.
  • An empty list counts as no answer, so an optional question answered with an empty list is not checked any further.

Tests

  • Unit tests added in SubmissionServiceTest; it passes on main and with the commit applied on stable5.4.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

An answer is a list of values, and the answer to a grid question an
object with the values by row, as the API describes it. Other values
are rejected as an invalid answer with a 400 instead of failing with a
server error, and an empty list counts as no answer, so an optional
question answered with an empty list is not checked any further.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews labels Nov 17, 2026
@AndyScherzinger AndyScherzinger self-assigned this Nov 17, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit 2954224 into main Nov 17, 2026
51 checks passed
@Chartman123
Chartman123 deleted the fix/submission-answer-must-be-list branch November 17, 2026 10:31
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 17, 2026
@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants