Repository navigation
fix(submission): only accept a list of values as an answer - #3904
Merged
Merged
Conversation
An answer is a list of values, and the answer to a grid question an object with the values by row, as the API describes it. Other values are rejected as an invalid answer with a 400 instead of failing with a server error, and an empty list counts as no answer, so an optional question answered with an empty list is not checked any further. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
|
/backport to stable5.4 |
Chartman123
approved these changes
Nov 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #3833, so it can be merged and backported on its own. The commit drops out of #3833 once this is merged.
Tests
SubmissionServiceTest; it passes onmainand with the commit applied onstable5.4.🤖 AI (if applicable)