Skip to content

fix(submission): only accept grid row and column ids as they are - #3903

Merged
Chartman123 merged 1 commit into
mainfrom
fix/submission-grid-option-ids
Nov 17, 2026
Merged

Chartman123 merged 1 commit into
mainfrom
fix/submission-grid-option-ids

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Split out of #3833, so it can be merged and backported on its own. The commit is unchanged and drops out of #3833 once this is merged.

  • The rows and columns of an answer to a grid question are compared as canonical integers with the option ids of the question, as the options of other questions are. A row or column id in another notation, such as "020" for the column 20, is rejected as not a valid option.

Tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

The rows and columns of an answer to a grid question are compared as
canonical integers with the ids of the options of the question, as the
options of other questions are. A row or column id in another notation,
such as "020" for the column 20, is not a valid option.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews labels Nov 17, 2026
@AndyScherzinger AndyScherzinger self-assigned this Nov 17, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 17, 2026
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit 52f0a02 into main Nov 17, 2026
51 checks passed
@Chartman123
Chartman123 deleted the fix/submission-grid-option-ids branch November 17, 2026 10:31
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 17, 2026
@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants