Skip to content

Fix pending tab closures not being removed - #7798

Open
mhammond wants to merge 1 commit into
mozilla:mainfrom
mhammond:push-psowvypnzvvq
Open

mhammond wants to merge 1 commit into
mozilla:mainfrom
mhammond:push-psowvypnzvvq

Conversation

@mhammond

Copy link
Copy Markdown
Member

remove_old_pending_closures had three bugs:

  • the per-device URL check compared new_remote_tabs.device_id to itself, so a URL open on any device in the batch kept every closure for it alive.
  • a device whose new record had no tabs never had its closures completed.
  • the timeout compared FxA device IDs to sync client IDs, so on desktop, where they differ, closures never timed out.

Noticed by claude when looking at #7793 and it seems legit!

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

remove_old_pending_closures had three bugs:
- the per-device URL check compared new_remote_tabs.device_id to itself,
  so a URL open on any device in the batch kept every closure for it alive.
- a device whose new record had no tabs never had its closures completed.
- the timeout compared FxA device IDs to sync client IDs, so on desktop,
  where they differ, closures never timed out.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant