Skip to content

Revert "Bug 2092979 - Use jsonschema-valid in FML tests (#7786)" - #7796

Merged
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-rzovwysvzpqp
Nov 17, 2026
Merged

freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-rzovwysvzpqp

Conversation

@freshstrangemusic

Copy link
Copy Markdown
Member

jsonschema-valid unfortunately requires an audit of a crate with a non-trivial amount of unsafe in order to merge in Firefox.

This reverts commit 9c49170.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-rzovwysvzpqp branch from 039fb7b to b4c6006 Compare November 17, 2026 21:56
jsonschema-valid unfortunately requires an audit of a crate with a
non-trivial amount of unsafe in order to merge in Firefox.

This revert keeps the dependency overrides for smallvec that were added
in the original patch.

This reverts commit 9c49170.
@freshstrangemusic
freshstrangemusic force-pushed the freshstrangemusic/push-rzovwysvzpqp branch from b4c6006 to e34c1f4 Compare November 17, 2026 21:57
@freshstrangemusic
freshstrangemusic added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit c4fc72f Nov 17, 2026
15 of 16 checks passed
@freshstrangemusic
freshstrangemusic deleted the freshstrangemusic/push-rzovwysvzpqp branch November 17, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants