Repository navigation
Allow mozilla-central to build the iOS megazords [ci full] - #7794
Merged
ahochheiden merged 2 commits intoNov 18, 2026
Merged
Conversation
ahochheiden
force-pushed
the
ios-megazords-in-mozilla-central
branch
from
November 17, 2026 20:51
791a0b4 to
b0b09aa
Compare
The `mozbuild-rustlib` feature makes `nss_sys` link NSS the way a self contained Rust artifact needs, which under `MOZ_NSS_STATIC` is the single `nss_rustlib` archive. No Focus component uses `rc_crypto`, so the Focus megazord depends on it and exports it only under that feature, to get `nss_sys` linked in, because `ohttp` needs NSS there. The megazords take the `active` feature of `glean-sym` only on iOS, where Glean is linked into the app. With `active`, `glean-sym` looks for Glean in libxul on other unix targets and does not compile outside unix, so the megazords leave it off there. They take `viaduct-backend-rust` only on Apple targets, because its native-tls needs OpenSSL elsewhere, and the Swift docs build compiles the megazord on macOS. The workspace hack stub gains the `megazord_ios` and `megazord_focus` features that the megazords name.
`HostRustProgram` in mozilla-central requires an explicit `[[bin]]` section. The workspace hack stub gains the `uniffi-bindgen-library-mode` feature that the tool names.
ahochheiden
force-pushed
the
ios-megazords-in-mozilla-central
branch
from
November 17, 2026 22:23
b0b09aa to
3e58df9
Compare
mhammond
approved these changes
Nov 18, 2026
mhammond
left a comment
Member
There was a problem hiding this comment.
bit of a rubber-stamp, but looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for building the application-services iOS libraries in mozilla-central.
The iOS megazords forward the
mozbuild-rustlibfeature torc_crypto, asmegazords/fullalready does, so that mozilla-central links its NSS into them. They takeviaduct-backend-rustonly on Apple targets and theactivefeature ofglean-symonly on iOS.uniffi-bindgen-library-modegets an explicit[[bin]]section, and the workspace hack stub gets the feature names these crates use.