Skip to content

Allow mozilla-central to build the iOS megazords [ci full] - #7794

Merged
ahochheiden merged 2 commits into
mozilla:mainfrom
ahochheiden:ios-megazords-in-mozilla-central
Nov 18, 2026
Merged

ahochheiden merged 2 commits into
mozilla:mainfrom
ahochheiden:ios-megazords-in-mozilla-central

Conversation

@ahochheiden

Copy link
Copy Markdown
Member

This is necessary for building the application-services iOS libraries in mozilla-central.

The iOS megazords forward the mozbuild-rustlib feature to rc_crypto, as megazords/full already does, so that mozilla-central links its NSS into them. They take viaduct-backend-rust only on Apple targets and the active feature of glean-sym only on iOS. uniffi-bindgen-library-mode gets an explicit [[bin]] section, and the workspace hack stub gets the feature names these crates use.

@ahochheiden
ahochheiden force-pushed the ios-megazords-in-mozilla-central branch from 791a0b4 to b0b09aa Compare November 17, 2026 20:51
The `mozbuild-rustlib` feature makes `nss_sys` link NSS the way a self
contained Rust artifact needs, which under `MOZ_NSS_STATIC` is the single
`nss_rustlib` archive. No Focus component uses `rc_crypto`, so the Focus
megazord depends on it and exports it only under that feature, to get
`nss_sys` linked in, because `ohttp` needs NSS there. The megazords take the
`active` feature of `glean-sym` only on iOS, where Glean is linked into the
app. With `active`, `glean-sym` looks for Glean in libxul on other unix
targets and does not compile outside unix, so the megazords leave it off
there. They take `viaduct-backend-rust` only on Apple targets, because its
native-tls needs OpenSSL elsewhere, and the Swift docs build compiles the
megazord on macOS.

The workspace hack stub gains the `megazord_ios` and `megazord_focus`
features that the megazords name.
`HostRustProgram` in mozilla-central requires an explicit `[[bin]]` section.
The workspace hack stub gains the `uniffi-bindgen-library-mode` feature that
the tool names.
@ahochheiden
ahochheiden force-pushed the ios-megazords-in-mozilla-central branch from b0b09aa to 3e58df9 Compare November 17, 2026 22:23

@mhammond mhammond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit of a rubber-stamp, but looks fine.

@ahochheiden
ahochheiden added this pull request to the merge queue Nov 18, 2026
Merged via the queue into mozilla:main with commit 7b24eb4 Nov 18, 2026
63 checks passed
@ahochheiden
ahochheiden deleted the ios-megazords-in-mozilla-central branch November 18, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants