Skip to content

Bug 2092275 - Remove Glean Kotlin generation from errorsupport - #7789

Open
bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-vpqqmkryrpzz
Open

bendk wants to merge 1 commit into
mozilla:mainfrom
bendk:bdk/push-vpqqmkryrpzz

Conversation

@bendk

@bendk bendk commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
  • Removed Kotlin code from errorsupport
  • Removed the glean-sym feature, it's now always on
  • Expose report_error so that Fenix can call from reportRustError.
  • Re-enabled the expected_failures metric

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk

bendk commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Don't merge until https://phabricator.services.mozilla.com/D343166 is approved to handle the breaking changes on the Android side.

Android side approved: https://phabricator.services.mozilla.com/D343166

@bendk
bendk requested a review from mhammond November 17, 2026 14:30
* Removed Kotlin code from errorsupport
* Removed the `glean-sym` feature, it's now always on
* Expose `report_error` so that Fenix can call from `reportRustError`.
* Re-enabled the `expected_failures` metric
@bendk
bendk force-pushed the bdk/push-vpqqmkryrpzz branch from 61eaf3e to 98076db Compare November 18, 2026 14:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant