Skip to content

fix(shell-bson-parser): _bsontype regression tests. COMPASS-11375 - #971

Merged
dudaschar merged 4 commits into
mainfrom
COMPASS-11375
Nov 13, 2026
Merged

dudaschar merged 4 commits into
mainfrom
COMPASS-11375

Conversation

@dudaschar

Copy link
Copy Markdown
Collaborator

^^^^^
Please fill the title above according to https://www.conventionalcommits.org/en/v1.0.0/.

type(scope): message

eg. fix(crud): updates ace editor width in agg pipeline view COMPASS-1111

Use feat, fix for user facing changes that should be part of release notes.

Semantic Versioning:

Package versions will be bumped automatically according to the PR title:

  • The words BREAKING CHANGE in the title will cause a major bump to all the packages changed in the PR. All dependants will also have a major bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).
  • A subject starting with feat will cause a minor bump to all the packages changed in the PR. All dependants will also have a minor bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).
  • Any other change to any package will cause a patch bump to the package and all its dependants.
    -->

Description

Open Questions

Checklist

@dudaschar dudaschar self-assigned this Nov 13, 2026
@dudaschar
dudaschar requested review from a team as code owners November 13, 2026 13:22
@dudaschar
dudaschar requested review from paula-stacho and a balanced review from Copilot November 13, 2026 13:22
@dudaschar dudaschar changed the title fix(shell-bson-parser): _bsontype regression tests. fix(shell-bson-parser): _bsontype regression tests. COMPASS-11375 Nov 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for this test-only change covering _bsontype handling.

No open issues 🎉

What changed in this PR

Adds _bsontype regression tests for the shell BSON parser’s toJSString function, covering plain objects and BSON Timestamp values without changing production code.

Changes:

  • Verifies that plain objects with their own _bsontype fields round-trip unchanged.
  • Verifies Timestamp serialization with a non-enumerable own _bsontype property, matching BSON 4 behavior.
File Description
packages/​shell-bson-parser/​src/​stringify.spec.ts Adds two regression tests for _bsontype handling.

Review effort: Balanced

@dudaschar
dudaschar enabled auto-merge (squash) November 13, 2026 15:16
@dudaschar
dudaschar merged commit 2628483 into main Nov 13, 2026
20 checks passed
@dudaschar
dudaschar deleted the COMPASS-11375 branch November 13, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants