Repository navigation
fix(shell-bson-parser): _bsontype regression tests. COMPASS-11375 - #971
Merged
Merged
Conversation
dudaschar
requested review from
paula-stacho
and
a balanced review from Copilot
November 13, 2026 13:22
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for this test-only change covering _bsontype handling.
No open issues 🎉
What changed in this PR
Adds _bsontype regression tests for the shell BSON parser’s toJSString function, covering plain objects and BSON Timestamp values without changing production code.
Changes:
- Verifies that plain objects with their own
_bsontypefields round-trip unchanged. - Verifies Timestamp serialization with a non-enumerable own
_bsontypeproperty, matching BSON 4 behavior.
| File | Description |
|---|---|
packages/shell-bson-parser/src/stringify.spec.ts |
Adds two regression tests for _bsontype handling. |
Review effort: Balanced
dudaschar
enabled auto-merge (squash)
November 13, 2026 15:16
esvm
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^^^^^
Please fill the title above according to https://www.conventionalcommits.org/en/v1.0.0/.
type(scope): message
eg. fix(crud): updates ace editor width in agg pipeline view COMPASS-1111
Use
feat,fixfor user facing changes that should be part of release notes.Semantic Versioning:
Package versions will be bumped automatically according to the PR title:
BREAKING CHANGEin the title will cause a major bump to all the packages changed in the PR. All dependants will also have a major bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).featwill cause a minor bump to all the packages changed in the PR. All dependants will also have a minor bump (dependencies, optionalDependencies, peerDependencies) or a patch bump (devDependencies).patchbump to the package and all its dependants.-->
Description
Open Questions
Checklist