Report strict-mode errors for class names eval and arguments by dmety · Pull Request #64682 · microsoft/TypeScript

Dmety (dmety) · 2026-10-07T23:38:51Z

bindClassLikeDeclaration did not call checkStrictModeEvalOrArguments, so class declarations and expressions named eval or arguments escaped TS1210. Call the check while binding class-like declarations and use the class-specific diagnostic for class names.

Add regression coverage for class declarations, named class expressions, ambient class declarations, and JavaScript with checkJs.

Validation:

Focused Go test passed: go -C ./tsc test '-run=TestLocal/(strictModeEvalOrArgumentsInClassName|strictModeReservedWordInClassDeclaration|argumentsReferenceInMethod4_Js)' ./internal/testrunner
npx hereby test, npx hereby lint, and npx hereby check:format were not run.

Copilot

🟡 Changes recommended

The unconditional check incorrectly rejects erased ambient class declarations.

1 open finding

Avoid TS1210 diagnostics for ambient class declarations · New

What changed in this PR

Adds strict-mode diagnostics for class names eval and arguments.

Changes:

Checks class names during binding.
Adds compiler regression coverage and diagnostic baselines.

File	Description
`tsc/internal/binder/binder.go`	Adds class-name validation and class-specific diagnostics.
`tsc/testdata/tests/cases/compiler/strictModeEvalOrArgumentsInClassName.ts`	Adds regression cases.
`tsc/testdata/baselines/reference/compiler/strictModeEvalOrArgumentsInClassName.errors.txt`	Records diagnostics.
`tsc/testdata/baselines/reference/compiler/strictModeEvalOrArgumentsInClassName.symbols`	Records symbols.
`tsc/testdata/baselines/reference/compiler/strictModeEvalOrArgumentsInClassName.types`	Records inferred types.

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Dmety (dmety) · 2026-10-08T08:10:57Z

@microsoft-github-policy-service agree

Copilot

🔵 Needs a closer look

The tests do not cover class names in an otherwise non-strict script.

0 open findings

1 resolved since last review

Avoid TS1210 diagnostics for ambient class declarations

Previously missed (1)

In code that hasn't changed since last review

Add sloppy-script regression test without module marker

tsc/internal/binder/binder.go:950

The regression test only exercises external modules (export {} appears in every executable test file, and the test also enables strict mode), so it does not lock down the important behavior added here: a class name must be checked even in an otherwise sloppy script. Please add at least one .ts or .js script case without a module marker and with alwaysStrict disabled; otherwise an implementation that incorrectly depends on the enclosing strict mode would still satisfy these baselines.

🧠 Review effort: Balanced

Jake Bailey (jakebailey) · 2026-11-02T21:46:47Z

TypeScript Bot (@typescript-bot) test it

typescript-automation · 2026-11-02T21:46:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-automation · 2026-11-02T22:22:01Z

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-automation · 2026-11-02T22:25:31Z

Jake Bailey (@jakebailey) Here are the results of running the user tests with tsc comparing baseline and pr:

Everything looks good!

typescript-automation · 2026-11-02T22:38:40Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - native}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_88,466	_88,466	_~	_~	_~	_{p=1.000 n=20}
_Types	_79,607	_79,607	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{107,510k (± 0.02%)}	_{107,492k (± 0.03%)}	_~	_107,336k	_107,606k	_{p=0.474 n=20}
_{Memory Allocs}	_{1,262,373 (± 0.00%)}	_{1,262,441 (± 0.01%)}	_~	_1,262,167	_1,262,950	_{p=0.402 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.023s (± 2.24%)}	_{0.023s (± 2.37%)}	_~	_0.020s	_0.025s	_{p=0.904 n=20}
_{Bind Time}	_{0.008s (± 5.01%)}	_{0.008s (± 4.54%)}	_~	_0.007s	_0.010s	_{p=0.051 n=20}
_{Check Time}	_{0.207s (± 0.71%)}	_{0.208s (± 0.60%)}	_~	_0.203s	_0.213s	_{p=0.085 n=20}
_{Emit Time}	_{0.130s (± 1.44%)}	_{0.128s (± 0.71%)}	_~	_0.126s	_0.133s	_{p=0.511 n=20}
_{Total Time}	_{0.370s (± 0.44%)}	_{0.370s (± 0.47%)}	_~	_0.365s	_0.379s	_{p=0.772 n=20}
_{angular-1 - native}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_586,553	_586,553	_~	_~	_~	_{p=1.000 n=20}
_Types	_241,682	_241,682	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{519,768k (± 0.02%)}	_{519,839k (± 0.02%)}	_~	_519,430k	_520,408k	_{p=0.245 n=20}
_{Memory Allocs}	_{7,798,849 (± 0.18%)}	_{7,790,557 (± 0.07%)}	_~	_7,781,272	_7,826,530	_{p=0.925 n=20}
_{Config Time}	_{0.009s (± 2.73%)}	_{0.009s (± 2.64%)}	_~	_0.008s	_0.009s	_{p=1.000 n=20}
_{Parse Time}	_{0.129s (± 5.00%)}	_{0.125s (± 2.33%)}	_~	_0.112s	_0.133s	_{p=0.568 n=20}
_{Bind Time}	_{0.046s (±10.93%)}	_{0.044s (±10.33%)}	_~	_0.038s	_0.067s	_{p=0.464 n=20}
_{Check Time}	_0s	_0s	_~	_~	_~	_{p=1.000 n=20}
_{Emit Time}	_{0.646s (± 0.78%)}	_{0.643s (± 1.04%)}	_~	_0.624s	_0.678s	_{p=0.239 n=20}
_{Total Time}	_{0.840s (± 1.03%)}	_{0.830s (± 0.92%)}	_~	_0.799s	_0.868s	_{p=0.106 n=20}
_{arktype - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_685,920	_685,920	_~	_~	_~	_{p=1.000 n=20}
_Types	_939,467	_939,467	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{495,290k (± 0.01%)}	_{495,333k (± 0.01%)}	_~	_495,124k	_495,574k	_{p=0.167 n=20}
_{Memory Allocs}	_{12,062,729 (± 0.01%)}	_{12,062,657 (± 0.01%)}	_~	_12,058,478	_12,070,125	_{p=0.947 n=20}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.041s (± 4.11%)}	_{0.042s (± 3.01%)}	_~	_0.037s	_0.047s	_{p=0.244 n=20}
_{Bind Time}	_{0.014s (± 9.57%)}	_{0.013s (± 9.95%)}	_~	_0.011s	_0.022s	_{p=0.157 n=20}
_{Check Time}	_{0.913s (± 0.95%)}	_{0.919s (± 1.41%)}	_~	_0.871s	_0.970s	_{p=0.507 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.997s (± 0.92%)}	_{1.002s (± 1.33%)}	_~	_0.952s	_1.061s	_{p=0.673 n=20}
_{class-transformer - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_45,376	_45,376	_~	_~	_~	_{p=1.000 n=20}
_Types	_7,573	_7,573	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{27,891k (± 0.04%)}	_{27,896k (± 0.04%)}	_~	_27,848k	_27,938k	_{p=0.634 n=20}
_{Memory Allocs}	_{248,299 (± 0.05%)}	_{248,298 (± 0.06%)}	_~	_247,747	_248,697	_{p=0.862 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.011s (± 3.47%)}	_{0.011s (± 7.35%)}	_~	_0.009s	_0.017s	_{p=0.486 n=20}
_{Bind Time}	_{0.003s (±12.18%)}	_{0.004s (±15.29%)}	_~	_0.002s	_0.007s	_{p=0.929 n=20}
_{Check Time}	_{0.008s (± 7.02%)}	_{0.008s (± 5.71%)}	_~	_0.006s	_0.009s	_{p=0.958 n=20}
_{Emit Time}	_{0.008s (±12.11%)}	_{0.008s (± 8.61%)}	_~	_0.006s	_0.011s	_{p=0.916 n=20}
_{Total Time}	_{0.031s (± 3.45%)}	_{0.032s (± 3.42%)}	_~	_0.027s	_0.037s	_{p=0.493 n=20}
_{effect - native}
_Errors	₁₂	₁₂	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_1,235,115	_1,235,115	_~	_~	_~	_{p=1.000 n=20}
_Types	_894,113	_894,113	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{950,048k (± 0.02%)}	_{949,882k (± 0.02%)}	_~	_949,292k	_950,540k	_{p=0.253 n=20}
_{Memory Allocs}	_{12,640,108 (± 0.02%)}	_{12,638,507 (± 0.03%)}	_~	_12,630,539	_12,662,957	_{p=0.414 n=20}
_{Config Time}	_0.002s	_0.002s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.145s (± 1.24%)}	_{0.145s (± 1.53%)}	_~	_0.137s	_0.158s	_{p=0.702 n=20}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{0.864s (± 0.86%)}	_{0.868s (± 0.84%)}	_~	_0.843s	_0.894s	_{p=0.449 n=20}
_{Emit Time}	_{0.483s (± 1.40%)}	_{0.480s (± 1.82%)}	_~	_0.445s	_0.513s	_{p=0.457 n=20}
_{Total Time}	_{1.583s (± 0.34%)}	_{1.584s (± 0.37%)}	_~	_1.563s	_1.611s	_{p=0.920 n=20}
_{mui-docs - native}
_Errors	_11,405	_11,405	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_3,784,019	_3,784,019	_~	_~	_~	_{p=1.000 n=20}
_Types	_1,355,974	_1,355,974	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{1,768,315k (± 0.07%)}	_{1,768,830k (± 0.08%)}	_~	_1,763,743k	_1,773,875k	_{p=0.620 n=20}
_{Memory Allocs}	_{25,756,876 (± 0.13%)}	_{25,765,826 (± 0.15%)}	_~	_25,644,586	_25,923,144	_{p=0.968 n=20}
_{Config Time}	_{0.009s (± 2.82%)}	_{0.008s (± 2.64%)}	_~	_0.008s	_0.009s	_{p=0.333 n=20}
_{Parse Time}	_{0.288s (± 2.86%)}	_{0.285s (± 2.46%)}	_~	_0.266s	_0.323s	_{p=0.490 n=20}
_{Bind Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{3.078s (± 0.81%)}	_{3.068s (± 0.68%)}	_~	_2.970s	_3.144s	_{p=0.441 n=20}
_{Emit Time}	_{0.250s (± 1.13%)}	_{0.256s (± 2.69%)}	_~	_0.238s	_0.299s	_{p=0.154 n=20}
_{Total Time}	_{4.131s (± 0.70%)}	_{4.118s (± 0.51%)}	_~	_4.021s	_4.187s	_{p=0.499 n=20}
_{sentry - native}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_4,793,245	_4,793,245	_~	_~	_~	_{p=1.000 n=20}
_Types	_2,606,905	_2,606,905	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{2,847,437k (± 0.03%)}	_{2,846,862k (± 0.04%)}	_~	_2,843,384k	_2,851,765k	_{p=0.262 n=20}
_{Memory Allocs}	_{75,240,230 (± 0.39%)}	_{75,018,407 (± 0.27%)}	_~	_74,530,442	_76,476,322	_{p=0.114 n=20}
_{Config Time}	_{0.025s (± 1.10%)}	_{0.025s (± 0.95%)}	_~	_0.024s	_0.026s	_{p=0.604 n=20}
_{Parse Time}	_{0.488s (± 5.76%)}	_{0.479s (± 5.13%)}	_~	_0.416s	_0.634s	_{p=0.673 n=20}
_{Bind Time}	_{0.148s (± 9.39%)}	_{0.150s (± 8.92%)}	_~	_0.118s	_0.216s	_{p=0.606 n=20}
_{Check Time}	_{6.631s (± 0.66%)}	_{6.574s (± 0.56%)}	_~	_6.442s	_6.725s	_{p=0.059 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{7.343s (± 0.70%)}	_{7.283s (± 0.55%)}	_~	_7.135s	_7.453s	_{p=0.073 n=20}
_{social-app - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_1,883,074	_1,883,074	_~	_~	_~	_{p=1.000 n=20}
_Types	_1,158,168	_1,158,168	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{966,992k (± 0.01%)}	_{966,860k (± 0.02%)}	_~	_966,048k	_967,257k	_{p=0.262 n=20}
_{Memory Allocs}	_{13,487,876 (± 0.13%)}	_{13,488,004 (± 0.13%)}	_~	_13,447,820	_13,581,135	_{p=0.883 n=20}
_{Config Time}	_{0.007s (± 2.02%)}	_{0.007s (± 2.86%)}	_~	_0.007s	_0.008s	_{p=0.407 n=20}
_{Parse Time}	_{0.161s (± 2.79%)}	_{0.163s (± 2.95%)}	_~	_0.144s	_0.188s	_{p=0.587 n=20}
_{Bind Time}	_{0.043s (± 8.33%)}	_{0.042s (± 6.95%)}	_~	_0.036s	_0.057s	_{p=0.941 n=20}
_{Check Time}	_{1.461s (± 1.11%)}	_{1.463s (± 1.10%)}	_~	_1.394s	_1.521s	_{p=0.794 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{1.690s (± 1.07%)}	_{1.694s (± 1.06%)}	_~	_1.640s	_1.758s	_{p=0.644 n=20}
_{strada-build-src - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_1,184,972	_1,184,972	_~	_~	_~	_{p=1.000 n=20}
_Types	_438,959	_438,959	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{1,168,531k (± 0.22%)}	_{1,171,538k (± 0.39%)}	_~	_1,157,286k	_1,200,459k	_{p=0.183 n=20}
_{Memory Allocs}	_{47,575,221 (± 0.10%)}	_{47,611,985 (± 0.09%)}	_~	_47,438,100	_47,812,997	_{p=0.355 n=20}
_{Config Time}	_{0.002s (±18.20%)}	_{0.002s (±21.60%)}	_~	_0.001s	_0.004s	_{p=0.423 n=20}
_{Parse Time}	_{0.137s (± 1.84%)}	_{0.139s (± 3.16%)}	_~	_0.131s	_0.176s	_{p=0.673 n=20}
_{Bind Time}	_0.000s	_{0.000s (±208.60%)}	_~	_0.000s	_0.001s	_{p=1.000 n=20}
_{Check Time}	_{0.791s (± 0.72%)}	_{0.799s (± 1.90%)}	_~	_0.776s	_0.932s	_{p=0.316 n=20}
_{Emit Time}	_{0.139s (± 1.26%)}	_{0.140s (± 1.68%)}	_~	_0.134s	_0.157s	_{p=0.258 n=20}
_{Total Time}	_{9.177s (± 0.71%)}	_{9.294s (± 2.60%)}	_~	_9.065s	_11.474s	_{p=0.327 n=20}
_{strada-compiler - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_263,511	_263,511	_~	_~	_~	_{p=1.000 n=20}
_Types	_196,116	_196,116	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{223,557k (± 0.02%)}	_{223,562k (± 0.02%)}	_~	_223,384k	_223,804k	_{p=0.899 n=20}
_{Memory Allocs}	_{2,390,631 (± 0.01%)}	_{2,390,913 (± 0.01%)}	_~	_2,389,936	_2,392,819	_{p=0.344 n=20}
_{Config Time}	_0.000s	_{0.000s (±208.60%)}	_~	_0.000s	_0.001s	_{p=1.000 n=20}
_{Parse Time}	_{0.050s (± 3.26%)}	_{0.053s (± 7.93%)}	_~	_0.046s	_0.088s	_{p=0.532 n=20}
_{Bind Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Check Time}	_{0.380s (± 1.10%)}	_{0.377s (± 0.86%)}	_~	_0.369s	_0.395s	_{p=0.218 n=20}
_{Emit Time}	_{0.048s (± 5.09%)}	_{0.050s (± 5.23%)}	_~	_0.044s	_0.058s	_{p=0.131 n=20}
_{Total Time}	_{0.504s (± 1.04%)}	_{0.508s (± 1.30%)}	_~	_0.494s	_0.554s	_{p=0.433 n=20}
_{t3code-server - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_4,350,661	_4,350,661	_~	_~	_~	_{p=1.000 n=20}
_Types	_3,040,644	_3,040,644	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{2,417,894k (± 0.03%)}	_{2,417,303k (± 0.03%)}	_~	_2,415,798k	_2,421,904k	_{p=0.102 n=20}
_{Memory Allocs}	_{37,210,543 (± 0.10%)}	_{37,215,133 (± 0.14%)}	_~	_37,102,944	_37,550,108	_{p=0.678 n=20}
_{Config Time}	_{0.003s (± 3.42%)}	_0.003s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.251s (± 2.89%)}	_{0.255s (± 4.45%)}	_~	_0.217s	_0.322s	_{p=0.683 n=20}
_{Bind Time}	_{0.091s (±11.45%)}	_{0.101s (±12.74%)}	_~	_0.073s	_0.147s	_{p=0.330 n=20}
_{Check Time}	_{5.869s (± 0.47%)}	_{5.895s (± 0.85%)}	_~	_5.730s	_6.116s	_{p=0.490 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{6.225s (± 0.48%)}	_{6.266s (± 0.83%)}	_~	_6.070s	_6.462s	_{p=0.224 n=20}
_{tanstack-router - native}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_571,756	_571,756	_~	_~	_~	_{p=1.000 n=20}
_Types	_397,689	_397,689	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{326,433k (± 0.02%)}	_{326,445k (± 0.01%)}	_~	_326,199k	_326,620k	_{p=0.678 n=20}
_{Memory Allocs}	_{4,338,196 (± 0.25%)}	_{4,335,133 (± 0.18%)}	_~	_4,317,513	_4,373,437	_{p=0.989 n=20}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.040s (± 4.04%)}	_{0.040s (± 4.20%)}	_~	_0.033s	_0.045s	_{p=0.973 n=20}
_{Bind Time}	_{0.012s (± 8.10%)}	_{0.014s (±13.46%)}	_~	_0.010s	_0.020s	_{p=0.770 n=20}
_{Check Time}	_{0.502s (± 0.89%)}	_{0.501s (± 0.66%)}	_~	_0.488s	_0.512s	_{p=0.952 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.574s (± 0.75%)}	_{0.573s (± 0.82%)}	_~	_0.555s	_0.588s	_{p=0.878 n=20}
_{ts-pre-modules - native}
_Errors	₈₇	₈₇	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_231,616	_231,616	_~	_~	_~	_{p=1.000 n=20}
_Types	_181,195	_181,195	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{193,000k (± 0.01%)}	_{192,966k (± 0.02%)}	_~	_192,805k	_193,052k	_{p=0.234 n=20}
_{Memory Allocs}	_{1,311,266 (± 0.02%)}	_{1,311,280 (± 0.02%)}	_~	_1,310,590	_1,312,630	_{p=0.941 n=20}
_{Config Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.043s (± 3.38%)}	_{0.043s (± 2.81%)}	_~	_0.038s	_0.048s	_{p=0.898 n=20}
_{Bind Time}	_{0.020s (± 5.26%)}	_{0.019s (± 6.76%)}	_~	_0.016s	_0.025s	_{p=0.181 n=20}
_{Check Time}	_{0.292s (± 0.86%)}	_{0.290s (± 0.77%)}	_~	_0.280s	_0.298s	_{p=0.202 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.361s (± 0.52%)}	_{0.358s (± 0.63%)}	_{-0.003s (- 0.73%)}	_0.352s	_0.366s	_{p=0.049 n=20}
_{vscode - native}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_7,633,382	_7,633,382	_~	_~	_~	_{p=1.000 n=20}
_Types	_4,490,354	_4,490,354	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{5,275,885k (± 0.02%)}	_{5,275,663k (± 0.02%)}	_~	_5,272,146k	_5,279,823k	_{p=0.841 n=20}
_{Memory Allocs}	_{57,772,495 (± 0.02%)}	_{57,776,000 (± 0.02%)}	_~	_57,754,555	_57,852,266	_{p=0.989 n=20}
_{Config Time}	_{0.033s (± 0.58%)}	_{0.034s (± 4.73%)}	_~	_0.032s	_0.048s	_{p=0.713 n=20}
_{Parse Time}	_{0.871s (± 1.58%)}	_{0.880s (± 1.70%)}	_~	_0.792s	_0.951s	_{p=0.344 n=20}
_{Bind Time}	_{0.304s (± 7.13%)}	_{0.295s (± 5.14%)}	_~	_0.277s	_0.431s	_{p=0.578 n=20}
_{Check Time}	_{7.026s (± 0.62%)}	_{7.026s (± 0.50%)}	_~	_6.866s	_7.214s	_{p=0.533 n=20}
_{Emit Time}	_{2.075s (± 6.33%)}	_{2.051s (± 5.79%)}	_~	_1.898s	_2.776s	_{p=0.365 n=20}
_{Total Time}	_{10.367s (± 1.12%)}	_{10.344s (± 1.06%)}	_~	_10.160s	_10.989s	_{p=0.304 n=20}
_{webpack - native}
_Errors	₆₁₁	₆₁₁	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_884,750	_884,750	_~	_~	_~	_{p=1.000 n=20}
_Types	_624,363	_624,363	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{651,715k (± 0.01%)}	_{651,804k (± 0.01%)}	_~	_651,571k	_652,204k	_{p=0.176 n=20}
_{Memory Allocs}	_{6,046,604 (± 0.05%)}	_{6,050,647 (± 0.09%)}	_~	_6,041,303	_6,089,505	_{p=0.341 n=20}
_{Config Time}	_0.004s	_0.004s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.128s (± 2.87%)}	_{0.132s (± 3.50%)}	_~	_0.113s	_0.150s	_{p=0.184 n=20}
_{Bind Time}	_{0.043s (±11.29%)}	_{0.040s (± 6.44%)}	_~	_0.031s	_0.052s	_{p=0.930 n=20}
_{Check Time}	_{1.085s (± 2.05%)}	_{1.083s (± 2.18%)}	_~	_0.992s	_1.136s	_{p=0.899 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{1.283s (± 2.12%)}	_{1.285s (± 2.26%)}	_~	_1.168s	_1.345s	_{p=0.920 n=20}
_{xstate-main - native}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=20}
_Symbols	_640,490	_640,490	_~	_~	_~	_{p=1.000 n=20}
_Types	_387,984	_387,984	_~	_~	_~	_{p=1.000 n=20}
_{Memory Used}	_{350,127k (± 0.02%)}	_{350,111k (± 0.03%)}	_~	_349,746k	_350,574k	_{p=0.743 n=20}
_{Memory Allocs}	_{3,968,685 (± 0.07%)}	_{3,969,741 (± 0.08%)}	_~	_3,958,489	_3,979,797	_{p=0.529 n=20}
_{Config Time}	_0.001s	_0.001s	_~	_~	_~	_{p=1.000 n=20}
_{Parse Time}	_{0.060s (± 2.43%)}	_{0.061s (± 2.61%)}	_~	_0.056s	_0.068s	_{p=0.355 n=20}
_{Bind Time}	_{0.019s (± 5.95%)}	_{0.019s (± 8.07%)}	_~	_0.016s	_0.026s	_{p=0.529 n=20}
_{Check Time}	_{0.394s (± 0.83%)}	_{0.393s (± 0.80%)}	_~	_0.383s	_0.410s	_{p=0.440 n=20}
_{Emit Time}	_0.000s	_0.000s	_~	_~	_~	_{p=1.000 n=20}
_{Total Time}	_{0.480s (± 0.93%)}	_{0.479s (± 0.83%)}	_~	_0.466s	_0.494s	_{p=0.743 n=20}

System info unknown

Hosts

native

Scenarios

Compiler-Unions - native
angular-1 - native
arktype - native
class-transformer - native
effect - native
mui-docs - native
sentry - native
social-app - native
strada-build-src - native
strada-compiler - native
t3code-server - native
tanstack-router - native
ts-pre-modules - native
vscode - native
webpack - native
xstate-main - native

_Benchmark	_Name	_Iterations
_Current	_pr	₂₀
_Baseline	_baseline	₂₀

Developer Information:

Download Benchmarks

typescript-automation · 2026-11-02T23:24:05Z

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos with tsc comparing baseline and pr:

Everything looks good!

Fix strict-mode class name diagnostics

32ff8f9

Copilot AI balanced review requested due to automatic review settings October 7, 2026 23:38

github-project-automation Bot added this to PR Backlog Oct 7, 2026

typescript-automation Bot added For Backlog Bug PRs that fix a backlog bug labels Oct 7, 2026

Copilot started reviewing on behalf of Dmety (dmety) October 7, 2026 23:40

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread tsc/internal/binder/binder.go Resolved

Skip strict-mode name checks for ambient classes

e8a9a3a

Jake Bailey (jakebailey) requested a balanced review from Copilot October 13, 2026 20:46

Copilot started reviewing on behalf of Jake Bailey (jakebailey) October 13, 2026 20:47

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Dmety (dmety) added 3 commits October 14, 2026 10:03

Merge branch 'main' into codex/issue-64661-strict-class-name

08c4b7c

Add non-strict script class-name coverage

679b347

Merge branch 'main' into codex/issue-64661-strict-class-name

06aeb63

Merge branch 'main' into codex/issue-64661-strict-class-name

346bc77

Jake Bailey (jakebailey) approved these changes Nov 3, 2026

View reviewed changes

github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Nov 3, 2026

Jake Bailey (jakebailey) enabled auto-merge November 3, 2026 19:30

Jake Bailey (jakebailey) added this pull request to the merge queue Nov 3, 2026

Merged via the queue into microsoft:main with commit fcf9a04 Nov 3, 2026
34 checks passed

github-project-automation Bot moved this from Needs merge to Done in PR Backlog Nov 3, 2026

Navigation Menu

Repository navigation

Report strict-mode errors for class names eval and arguments - #64682

Report strict-mode errors for class names eval and arguments#64682
Jake Bailey (jakebailey) merged 6 commits into
microsoft:mainfrom
dmety:codex/issue-64661-strict-class-name

Dmety (dmety) commented Oct 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Dmety (dmety) commented Oct 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Jake Bailey (jakebailey) commented Nov 2, 2026

Uh oh!

typescript-automation Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

typescript-automation Bot commented Nov 2, 2026

Uh oh!

typescript-automation Bot commented Nov 2, 2026

Uh oh!

typescript-automation Bot commented Nov 2, 2026

tsc

Uh oh!

typescript-automation Bot commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Dmety (dmety) commented Oct 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Dmety (dmety) commented Oct 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Jake Bailey (jakebailey) commented Nov 2, 2026

Uh oh!

typescript-automation Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-automation Bot commented Nov 2, 2026

Uh oh!

typescript-automation Bot commented Nov 2, 2026

Uh oh!

typescript-automation Bot commented Nov 2, 2026

tsc

Uh oh!

typescript-automation Bot commented Nov 2, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-automation Bot commented Nov 2, 2026 •

edited

Loading