Add --disableDynamicImportExtensionRewriting (#65289)

Author: andrewbranch

packages/typescript/schemas/jsconfig.schema.json

@@ -1428,6 +1428,19 @@
                     "default": false,
                     "markdownDescription": "Disable emitting comments.\n\nSee the [TSConfig reference](https://www.typescriptlang.org/tsconfig/#removeComments)."
                 },
+                "disableDynamicImportExtensionRewriting": {
+                    "anyOf": [
+                        {
+                            "type": "boolean"
+                        },
+                        {
+                            "type": "null"
+                        }
+                    ],
+                    "description": "Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled.",
+                    "default": false,
+                    "markdownDescription": "Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled.\n\nSee the [TSConfig reference](https://www.typescriptlang.org/tsconfig/#disableDynamicImportExtensionRewriting)."
+                },
                 "rewriteRelativeImportExtensions": {
                     "anyOf": [
                         {

packages/typescript/schemas/tsconfig.schema.json

@@ -1427,6 +1427,19 @@
                     "default": false,
                     "markdownDescription": "Disable emitting comments.\n\nSee the [TSConfig reference](https://www.typescriptlang.org/tsconfig/#removeComments)."
                 },
+                "disableDynamicImportExtensionRewriting": {
+                    "anyOf": [
+                        {
+                            "type": "boolean"
+                        },
+                        {
+                            "type": "null"
+                        }
+                    ],
+                    "description": "Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled.",
+                    "default": false,
+                    "markdownDescription": "Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled.\n\nSee the [TSConfig reference](https://www.typescriptlang.org/tsconfig/#disableDynamicImportExtensionRewriting)."
+                },
                 "rewriteRelativeImportExtensions": {
                     "anyOf": [
                         {

packages/typescript/src/api/compilerOptions.generated.ts

@@ -97,6 +97,7 @@ export interface CompilerOptions {
     resolvePackageJsonExports?: boolean | undefined;
     resolvePackageJsonImports?: boolean | undefined;
     removeComments?: boolean | undefined;
+    disableDynamicImportExtensionRewriting?: boolean | undefined;
     rewriteRelativeImportExtensions?: boolean | undefined;
     reactNamespace?: string | undefined;
     rootDir?: RootedDirectoryPath | undefined;

packages/typescript/src/api/proto.generated.ts

@@ -1872,6 +1872,7 @@ export interface RawCompilerOptions {
     resolvePackageJsonExports?: boolean | undefined;
     resolvePackageJsonImports?: boolean | undefined;
     removeComments?: boolean | undefined;
+    disableDynamicImportExtensionRewriting?: boolean | undefined;
     rewriteRelativeImportExtensions?: boolean | undefined;
     reactNamespace?: string | undefined;
     rootDir?: string | undefined;

tools/scripts/tsc/options.ts

@@ -994,6 +994,19 @@ export const options: OptionsModel = {
                 description: diagnostic("Disable emitting comments."),
             },
         },
+        {
+            name: "disableDynamicImportExtensionRewriting",
+            type: "Tristate",
+            declaration: {
+                group: "optionsForCompiler",
+                affectsSemanticDiagnostics: true,
+                affectsEmit: true,
+                affectsBuildInfo: true,
+                category: diagnostic("Modules"),
+                description: diagnostic("Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled."),
+                defaultValueDescription: false,
+            },
+        },
         {
             name: "rewriteRelativeImportExtensions",
             type: "Tristate",
@@ -1780,6 +1793,7 @@ export const options: OptionsModel = {
             "moduleSuffixes",
             "allowImportingTsExtensions",
             "rewriteRelativeImportExtensions",
+            "disableDynamicImportExtensionRewriting",
             "resolvePackageJsonExports",
             "resolvePackageJsonImports",
             "customConditions",

tsc/internal/checker/checker.go

@@ -8485,7 +8485,9 @@ func (c *Checker) checkImportCallExpression(node *ast.Node) *Type {
 		return c.createPromiseReturnType(node, c.anyType) //nolint:customlint // no arguments to check
 	}
 	specifier := args[0]
-	if c.compilerOptions.RewriteRelativeImportExtensions.IsTrue() && !ast.IsStringLiteralLike(specifier) {
+	if c.compilerOptions.RewriteRelativeImportExtensions.IsTrue() &&
+		!c.compilerOptions.DisableDynamicImportExtensionRewriting.IsTrue() &&
+		!ast.IsStringLiteralLike(specifier) {
 		c.checkExternalEmitHelpers(node, ExternalEmitHelpersRewriteRelativeImportExtension)
 	}
 	specifierType := c.checkExpressionCached(specifier)
@@ -8541,6 +8543,7 @@ func (c *Checker) checkImportCallExpression(node *ast.Node) *Type {
  */
 func (c *Checker) checkCallExpression(node *ast.Node, checkMode CheckMode) *Type {
 	if c.compilerOptions.RewriteRelativeImportExtensions.IsTrue() &&
+		!c.compilerOptions.DisableDynamicImportExtensionRewriting.IsTrue() &&
 		ast.IsInJSFile(node) && ast.IsRequireCall(node, false /*requireStringLiteralLikeArgument*/) &&
 		!ast.IsStringLiteralLike(node.Arguments()[0]) {
 		c.checkExternalEmitHelpers(node, ExternalEmitHelpersRewriteRelativeImportExtension)

tsc/internal/core/options_generated.go

@@ -1656,6 +1656,7 @@
     "This_operation_can_be_simplified_This_shift_is_identical_to_0_1_2_6807": "This operation can be simplified. This shift is identical to `{0} {1} {2}`.",
     "Enable_lib_replacement_6808": "Enable lib replacement.",
     "Ensure_types_are_ordered_stably_and_deterministically_across_compilations_6809": "Ensure types are ordered stably and deterministically across compilations.",
+    "Disable_runtime_rewriting_of_file_extensions_in_non_literal_import_and_require_calls_when_rewriteRel_6810": "Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled.",
     "one_of_Colon_6900": "one of:",
     "one_or_more_Colon_6901": "one or more:",
     "type_Colon_6902": "type:",

tsc/internal/diagnostics/diagnosticMessages.generated.json

@@ -6653,6 +6653,10 @@
         "category": "Message",
         "code": 6809
     },
+    "Disable runtime rewriting of file extensions in non-literal 'import()' and 'require()' calls when 'rewriteRelativeImportExtensions' is enabled.": {
+        "category": "Message",
+        "code": 6810
+    },
 
     "one of:": {
         "category": "Message",