Remove unused parameters from recursive functions (#65129)

Author: jakebailey

tsc/internal/checker/checker.go

@@ -6495,18 +6495,18 @@ func (c *Checker) getIterationTypesOfIterable(t *Type, use IterationUse, errorNo
 		}
 		noCache = true
 	}
-	result := c.getIterationTypesOfIterableWorker(t, use, errorNode, noCache)
+	result := c.getIterationTypesOfIterableWorker(t, use, errorNode)
 	if !noCache {
 		c.iterationTypesCache[key] = result
 	}
 	return result
 }
 
-func (c *Checker) getIterationTypesOfIterableWorker(t *Type, use IterationUse, errorNode *ast.Node, noCache bool) IterationTypes {
+func (c *Checker) getIterationTypesOfIterableWorker(t *Type, use IterationUse, errorNode *ast.Node) IterationTypes {
 	if t.flags&TypeFlagsUnion != 0 {
 		allIterationTypes := make([]IterationTypes, 0, len(t.Types()))
 		for _, constituent := range t.Types() {
-			iterationTypes := c.getIterationTypesOfIterableWorker(constituent, use, nil, noCache)
+			iterationTypes := c.getIterationTypesOfIterableWorker(constituent, use, nil)
 			if !iterationTypes.hasTypes() {
 				if errorNode != nil {
 					c.addDeferredDiagnostic(func() {

tsc/internal/ls/completions.go

@@ -1923,7 +1923,6 @@ func (l *LanguageService) completionInfoFromData(
 				caseBlock.AsCaseBlock(),
 				file,
 				position,
-				compilerOptions,
 				l.program,
 				typeChecker,
 			)
@@ -6592,7 +6591,6 @@ func (l *LanguageService) getExhaustiveCaseSnippets(
 	caseBlock *ast.CaseBlock,
 	file *ast.SourceFile,
 	position int,
-	options *core.CompilerOptions,
 	program *compiler.Program,
 	c *checker.Checker,
 ) (*lsproto.CompletionItem, error) {
@@ -6601,7 +6599,6 @@ func (l *LanguageService) getExhaustiveCaseSnippets(
 	if switchType != nil && switchType.IsUnion() && core.Every(switchType.Types(), isLiteral) {
 		// Collect constant values in existing clauses.
 		tracker := newCaseClauseTracker(c, clauses)
-		target := options.GetEmitScriptTarget()
 		quotePreference := lsutil.GetQuotePreference(file, l.UserPreferences())
 		// Tolerate a nil import adder in untitled files.
 		var importAdder autoimport.ImportAdder
@@ -6646,7 +6643,7 @@ func (l *LanguageService) getExhaustiveCaseSnippets(
 				if typeNode == nil {
 					return nil, nil
 				}
-				expr := typeNodeToExpression(typeNode, target, quotePreference, factory)
+				expr := typeNodeToExpression(typeNode, quotePreference, factory)
 				if expr == nil {
 					return nil, nil
 				}
@@ -6727,24 +6724,21 @@ func (l *LanguageService) getExhaustiveCaseSnippets(
 
 func typeNodeToExpression(
 	typeNode *ast.TypeNode,
-	target core.ScriptTarget,
 	quotePreference lsutil.QuotePreference,
 	factory *ast.NodeFactory,
 ) *ast.Expression {
 	switch typeNode.Kind {
 	case ast.KindTypeReference:
 		typeName := typeNode.AsTypeReferenceNode().TypeName
-		return entityNameToExpression(typeName, target, quotePreference, factory)
+		return entityNameToExpression(typeName, factory)
 	case ast.KindIndexedAccessType:
 		objectExpression := typeNodeToExpression(
 			typeNode.AsIndexedAccessTypeNode().ObjectType,
-			target,
 			quotePreference,
 			factory,
 		)
 		indexExpression := typeNodeToExpression(
 			typeNode.AsIndexedAccessTypeNode().IndexType,
-			target,
 			quotePreference,
 			factory,
 		)
@@ -6767,7 +6761,6 @@ func typeNodeToExpression(
 	case ast.KindParenthesizedType:
 		expr := typeNodeToExpression(
 			typeNode.AsParenthesizedTypeNode().Type,
-			target,
 			quotePreference,
 			factory,
 		)
@@ -6779,7 +6772,7 @@ func typeNodeToExpression(
 		}
 		return factory.NewParenthesizedExpression(expr)
 	case ast.KindTypeQuery:
-		return entityNameToExpression(typeNode.AsTypeQueryNode().ExprName, target, quotePreference, factory)
+		return entityNameToExpression(typeNode.AsTypeQueryNode().ExprName, factory)
 	case ast.KindImportType:
 		debug.Fail(`We should not get an import type after calling 'typeToAutoImportableTypeNode'.`)
 		return nil
@@ -6789,15 +6782,13 @@ func typeNodeToExpression(
 
 func entityNameToExpression(
 	entityName *ast.EntityName,
-	target core.ScriptTarget,
-	quotePreference lsutil.QuotePreference,
 	factory *ast.NodeFactory,
 ) *ast.Expression {
 	if ast.IsIdentifier(entityName) {
 		return entityName
 	}
 	return factory.NewPropertyAccessExpression(
-		entityNameToExpression(entityName.AsQualifiedName().Left, target, quotePreference, factory),
+		entityNameToExpression(entityName.AsQualifiedName().Left, factory),
 		nil, /*questionDotToken*/
 		entityName.AsQualifiedName().Right,
 		ast.NodeFlagsNone,