Skip to content

November cleanup - #327

Open
Gustavo Hidalgo (ghidalgo3) wants to merge 3 commits into
mainfrom
guhidalgo/cleanup
Open

Gustavo Hidalgo (ghidalgo3) wants to merge 3 commits into
mainfrom
guhidalgo/cleanup

Conversation

@ghidalgo3

Copy link
Copy Markdown
Collaborator
  1. Define a common set of dependencies in a pyproject.toml and generate a requirements.txt
  2. Replace black and flake8 with ruff, format all notebooks.
  3. Remove Docker requirements (not needed, makes working with Jupyter very annoying)
  4. Upgrade minimum Python version to 3.12

- Updated Python version from 3.9 and 3.11 to 3.12 in CI workflows and project files.
- Removed Dockerfile and docker-compose.yml as the project no longer relies on Docker for development.
- Added installation script to set up a virtual environment using `uv`.
- Updated CONTRIBUTING.md and README.md to reflect new setup instructions and environment requirements.
- Regenerated requirements.txt based on updated dependencies in pyproject.toml.
Comment thread scripts/install
#!/usr/bin/env bash
set -euo pipefail

if ! command -v uv >/dev/null 2>&1; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to require the use of uv for the virtual env for the install script? I prefer to leave the script to install the requirements wherever the user wants, and leave the venv setup as seprate. Maybe still include in a script still but a separate script, or an optional

Comment thread scripts/test

if ! command -v uv >/dev/null 2>&1; then
printf '%s\n' \
'uv is required. See https://docs.astral.sh/uv/getting-started/installation/.' >&2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why uv specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants