Skip to content

Update data widgets screenshot baseline - #2527

Merged
leonardomendix merged 1 commit into
mainfrom
test/data-widget-update-screenshot
Nov 12, 2026
Merged

leonardomendix merged 1 commit into
mainfrom
test/data-widget-update-screenshot

Conversation

@leonardomendix

Copy link
Copy Markdown
Collaborator

Pull request type

Test related change (New E2E test, test automation, etc.)


Description

Update data widgets screenshot baseline.

@leonardomendix
leonardomendix requested a review from a team as a code owner November 12, 2026 14:43
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
packages/pluggableWidgets/datagrid-dropdown-filter-web/e2e/DataGridDropDownFilter.spec.js-snapshots/dataGridDropDownFilter-undefined-chromium-linux.png Updated existing screenshot baseline
packages/pluggableWidgets/datagrid-number-filter-web/e2e/DataGridNumberFilter.spec.js-snapshots/dataGridNumberFilter-chromium-linux.png Updated existing screenshot baseline

Skipped (out of scope): none. The PR contains only binary baseline images.

CI: pending: Plan E2E matrix, Read versions file, Run code quality check, sigridci · unrelated failures: security/snyk (external scanner, no code changed)


Questions

  • The dropdown filter baseline name contains undefined (dataGridDropDownFilter-undefined-chromium-linux.png). The file already exists in the repo, so this PR doesn't introduce it. Is it worth fixing the screenshot name in the spec separately?
  • Images can't be diffed in text. Please confirm the E2E run on this PR passes against the new baselines, and that the visual changes are intended.

Positives

  • The change is limited to the two baseline PNGs, with no code or XML changes. No changelog entry is needed.
  • Both files replace existing committed baselines, so toHaveScreenshot keeps a committed baseline.

@leonardomendix
leonardomendix merged commit 81b0c82 into main Nov 12, 2026
15 of 16 checks passed
@leonardomendix
leonardomendix deleted the test/data-widget-update-screenshot branch November 12, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants