Skip to content

[WC-3418]: Fix combobox accessibility issues - #2513

Open
iobuhov wants to merge 2 commits into
mainfrom
claude/charming-euler-hidye1
Open

iobuhov wants to merge 2 commits into
mainfrom
claude/charming-euler-hidye1

Conversation

@iobuhov

@iobuhov iobuhov commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Mark the decorative down-arrow and clear-button SVGs as aria-hidden so screen readers no longer announce them as images, and skip rendering the no-options option when there is no text, so an empty combobox exposes no empty node.

Pull request type

Bug fix (non-breaking change which fixes an issue)

🤖 Generated with Claude Code

@iobuhov
iobuhov requested a review from a team as a code owner November 4, 2026 15:04
@github-actions

This comment has been minimized.

…ive tech

Mark the decorative down-arrow and clear-button SVGs as aria-hidden so screen
readers no longer announce them as images, and skip rendering the no-options
option when there is no text, so an empty combobox exposes no empty node.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PZAW6LGnWBWa2De3ZYofRG
@iobuhov
iobuhov force-pushed the claude/charming-euler-hidye1 branch from bd2f5b4 to 6c2e10d Compare November 10, 2026 16:32
@github-actions

This comment has been minimized.

…configured

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
combobox-web/src/assets/icons.tsx aria-hidden and focusable="false" added to the ClearButton and DownArrow SVGs
combobox-web/src/components/Placeholder.tsx NoOptionsPlaceholder returns null when there is no text
combobox-web/src/assets/__tests__/icons.spec.tsx, combobox-web/src/components/__tests__/ComboboxMenuWrapperEmptyState.spec.tsx New unit tests
combobox-web/src/__tests__/__snapshots__/* Snapshots updated for the new SVG attributes
combobox-web/e2e/ComboboxKeyboardNavigation.spec.js, combobox-web/e2e/ComboboxMenuFeatures.spec.js E2E expectations updated: no placeholder when no text is configured
combobox-web/CHANGELOG.md User-facing entry under Unreleased

CI: pending: Run code quality check, Plan E2E matrix, sigridci, code/snyk · unrelated failures: security/snyk (external scanner)


Positives

  • Small, focused accessibility fix with a user-facing changelog entry.
  • Unit tests cover both the empty and non-empty no-options cases, and the E2E specs are updated to match the new behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants