Repository navigation
Add cross-platform cmark-gfm conversion and release CI - #41
djmsampson wants to merge 104 commits into
Conversation
There was a problem hiding this comment.
PR Review Comments
-
P2 —
tbx/docmaker/docconvert.m:318: Preserve GitLab LaTeX normalization.This now always calls
removeItalicTags, but GitLab’s Markdown API returns math in spans marked withdata-math-style. Without the removedwrapMathSpanshandling, those expressions don’t get$...$or$$...$$delimiters, so MathJax won’t render them. Please restore GitLab-specific normalization and coverConverter="gitlab"withInterpreter="latex"using a response fixture. -
P2 —
src/emoji.c:85: Track inline code spans across lines.This scans backtick spans one line at a time. CommonMark code spans can contain line breaks, so a shortcode on a later line inside a span, such as
`code\n:smile:\ncode`, gets expanded despite the documented promise to preserve shortcodes in code spans. -
P2 —
src/emoji.c:45: Validate fenced-code closers.is_fence_lineaccepts any line starting with three or more fence characters. While inside a code block, a line like```not-a-closeris therefore treated as the closing fence, even though CommonMark requires only whitespace after the fence. Shortcodes later in the block can then be expanded. -
P2 —
src/emoji.c:130: Handle balanced parentheses in link destinations.The destination scan stops at the first
). For a valid destination with balanced parentheses, such as[link](path_(part):smile:), it resumes inside the destination and expands the shortcode, contrary to the documented behavior. -
P2 —
buildfile.m:208: Exercise the pre-R2026b packaging branch in CI.The package task’s older-release license fallback is only covered when
UseLicenseBSDis absent. The older-release CI matrix runs tests, not packaging, and does not include R2026a; the package job uses the latest MATLAB. Please add an R2026a package smoke test to exercise this compatibility path.
Summary
cmarkthe offline default.apimd2html, and support private instances through configurable hostnames.Validation
buildtool("test")passed all 27 tests; the MEX rebuilt successfully and code/project checks passed.buildtool("package")succeeded on R2026b.