Repository navigation
fix(stack): preserve literal empty struct arguments - #98
Open
ViktorBystrov72 wants to merge 1 commit into
Open
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Signed-off-by: Виктор Быстров <anatema@bk.ru>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
- Coverage 83.4% 80.2% -3.2%
=======================================
Files 12 23 +11
Lines 2768 2269 -499
=======================================
- Hits 2308 1819 -489
- Misses 399 450 +51
+ Partials 61 0 -61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source augmentation drops literal
struct{}parameters because they have no stack words. Achan struct{}parameter is also displayed with an unknown element type, and treating the channel like an interface consumes the next argument's word.Recognize literal empty struct types, render fixed empty struct arguments without consuming words, and consume one word for channel arguments. This preserves subsequent arguments in both aggregate-form and older flat-word stack traces.
Fixes #59.
Validation on Go 1.27.3:
make fix,make verify,make test, andmake test-racepassed, including coverage and benchmark smoke checks.