Repository navigation
Close open submessage when move-assigning onto a writer - #167
Merged
Merged
Conversation
Move-assigning onto a basic_pbf_writer for an open submessage overwrote it without closing the submessage, leaving the parent stuck with an open submessage. Self-move-assignment also invalidated the writer. Use move-and-swap so the old state is closed by the temporary's destructor, the same way it is when a writer goes out of scope.
joto
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move-assigning onto a
basic_pbf_writerfor an open submessage overwrote it without closing the submessage, leaving the parent stuck with an open submessage. Self-move-assignment also invalidated the writer.The fix is to simply use a move-and-swap so the old state is closed by the temporary object's destructor, the same way it is when a writer goes out of scope.