Repository navigation
fix: accept public IP destinations for channel SSH egress - #213
Merged
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH approval rejected public IP addresses because the tool and raw tunnel list reused the DNS-only credential-host validator. Add a separate raw-destination validator accepting public IPv4/IPv6 and use it both when saving egressRawHosts and when building the proxy raw passthrough policy. Keep credential substitution rules DNS-only.
Exact public IPs now reach the durable worker approval card without DNS. Approved IPs select a raw SSH tunnel rather than TLS; network-off, private/loopback/metadata, mapped-private and scoped-IP protections remain enforced. Updated the operating guide and live acceptance definitions for both engines.
Validation: 68 targeted egress/MCP tests passed; full coverage suite 4,225 passed, 39 skipped, zero failures. Static/secret scans and DCO passed; independent security review found no blockers. Live Slack/SSH acceptance pending. The existing authorization security-coverage floor is tracked separately.